From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake.conf: Set BB_CONSOLELOG so we log console messages by default
Date: Thu, 24 Nov 2011 16:22:19 +0000 [thread overview]
Message-ID: <1322151739.10928.3.camel@ted> (raw)
In-Reply-To: <4ECE6D2C.1000704@linux.intel.com>
On Thu, 2011-11-24 at 08:13 -0800, Darren Hart wrote:
> I believe this is the fix for Yocto Bug 1771? If so, awesome! A one
> liner, something to be said for really knowing the codebase.
It has a dependent on a ~5 line change to bitbake over on bitbake-devel
but yes, it fixes 1771.
> I would only suggest a commit log which includes the bug line,
> motivation and the approach taken, per the contribution guidelines.
> Maybe something like:
>
> """""
> Fixes [YOCTO #1771]
>
> The console log is often helpful for debugging issues. Difficult to
> reproduce bugs would benefit from a log being generated by default as it
> may be difficult to come by after the fact. Log to
> tmp/cooker.log.${DATETIME} by default.
> """""
FWIW most of the commit message is over on bitbake-devel but I should
have referenced the bug number, yes.
Cheers,
Richard
prev parent reply other threads:[~2011-11-24 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 14:58 [PATCH] bitbake.conf: Set BB_CONSOLELOG so we log console messages by default Richard Purdie
2011-11-24 16:13 ` Darren Hart
2011-11-24 16:22 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322151739.10928.3.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox