Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] Add PATCHRESOLVE to excluded vars for generating sstate-cache
@ 2011-11-17 22:42 Matthew McClintock
  2011-11-25  0:04 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew McClintock @ 2011-11-17 22:42 UTC (permalink / raw)
  To: openembedded-core

The method of resolving the patch should not effect the sstate-cache
signature.

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
I'm not 100% sure about this one either - should we even generate
sstate-cache at all if we have a scenario where we try to resolve
a patch?

 meta/classes/patch.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/patch.bbclass b/meta/classes/patch.bbclass
index 7622163..5f9765c 100644
--- a/meta/classes/patch.bbclass
+++ b/meta/classes/patch.bbclass
@@ -138,7 +138,7 @@ python patch_do_patch() {
 			raise bb.build.FuncFailed(str(sys.exc_value))
 		resolver.Resolve()
 }
-patch_do_patch[vardepsexclude] = "DATE SRCDATE"
+patch_do_patch[vardepsexclude] = "DATE SRCDATE PATCHRESOLVE"
 
 addtask patch after do_unpack
 do_patch[dirs] = "${WORKDIR}"
-- 
1.7.6.1





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add PATCHRESOLVE to excluded vars for generating sstate-cache
  2011-11-17 22:42 [PATCH] Add PATCHRESOLVE to excluded vars for generating sstate-cache Matthew McClintock
@ 2011-11-25  0:04 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2011-11-25  0:04 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Thu, 2011-11-17 at 16:42 -0600, Matthew McClintock wrote:
> The method of resolving the patch should not effect the sstate-cache
> signature.
> 
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
> I'm not 100% sure about this one either - should we even generate
> sstate-cache at all if we have a scenario where we try to resolve
> a patch?
> 
>  meta/classes/patch.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Merged to master, thanks.

In answer to the question, there clearly shouldn't be a dependency on
this variable. We can depend on the variable even if the conditional
code using it doesn't actually use the code as the dependency analysis
doesn't account for conditional code paths.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-25  0:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-17 22:42 [PATCH] Add PATCHRESOLVE to excluded vars for generating sstate-cache Matthew McClintock
2011-11-25  0:04 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox