* [PATCH] consolekit: package /var/log/Consolekit
@ 2011-11-30 8:24 Koen Kooi
2011-11-30 15:11 ` Richard Purdie
2011-11-30 17:38 ` Richard Purdie
0 siblings, 2 replies; 8+ messages in thread
From: Koen Kooi @ 2011-11-30 8:24 UTC (permalink / raw)
To: openembedded-core; +Cc: Koen Kooi
This fixes startup issues like this:
2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: ** (process:91): WARNING **: Couldn't create log file /var/log/ConsoleKit/history (No such file or directory)
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
.../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
index 562dfb3..a02203c 100644
--- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
+++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
-PR = "r5"
+PR = "r6"
LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
@@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
"
-FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
+FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
FILES_${PN}-dbg += "${base_libdir}/security/.debug"
PACKAGES =+ "pam-plugin-ck-connector"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 8:24 [PATCH] consolekit: package /var/log/Consolekit Koen Kooi
@ 2011-11-30 15:11 ` Richard Purdie
2011-11-30 17:38 ` Richard Purdie
1 sibling, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2011-11-30 15:11 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
> This fixes startup issues like this:
>
> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: ** (process:91): WARNING **: Couldn't create log file /var/log/ConsoleKit/history (No such file or directory)
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 8:24 [PATCH] consolekit: package /var/log/Consolekit Koen Kooi
2011-11-30 15:11 ` Richard Purdie
@ 2011-11-30 17:38 ` Richard Purdie
2011-11-30 17:50 ` Koen Kooi
2011-11-30 17:51 ` Mark Hatle
1 sibling, 2 replies; 8+ messages in thread
From: Richard Purdie @ 2011-11-30 17:38 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi
On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
> This fixes startup issues like this:
>
> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
> (process:91): WARNING **: Couldn't create log
> file /var/log/ConsoleKit/history (No such file or directory)
>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> .../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> index 562dfb3..a02203c 100644
> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
>
> -PR = "r5"
> +PR = "r6"
>
> LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
> ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
> "
>
> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>
> PACKAGES =+ "pam-plugin-ck-connector"
Looks like this is breaking builds:
| consolekit ##################################################
| error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
:(
http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 17:38 ` Richard Purdie
@ 2011-11-30 17:50 ` Koen Kooi
2011-11-30 20:19 ` Richard Purdie
2011-11-30 17:51 ` Mark Hatle
1 sibling, 1 reply; 8+ messages in thread
From: Koen Kooi @ 2011-11-30 17:50 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2451 bytes --]
Op 30 nov. 2011, om 18:38 heeft Richard Purdie het volgende geschreven:
> On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
>> This fixes startup issues like this:
>>
>> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
>> (process:91): WARNING **: Couldn't create log
>> file /var/log/ConsoleKit/history (No such file or directory)
>>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> .../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> index 562dfb3..a02203c 100644
>> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
>> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
>> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
>>
>> -PR = "r5"
>> +PR = "r6"
>>
>> LICENSE = "GPLv2+"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
>> ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
>> "
>>
>> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>>
>> PACKAGES =+ "pam-plugin-ck-connector"
>
> Looks like this is breaking builds:
>
> | consolekit ##################################################
> | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
>
> :(
>
> http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
I suspect that's another victim of fs-perms.txt and rpm, it seems to break if /var/log is a symlink in other packages. I am going to argue that the breakage isn't a bug in consolekit :)
regards,
Koen
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 17:38 ` Richard Purdie
2011-11-30 17:50 ` Koen Kooi
@ 2011-11-30 17:51 ` Mark Hatle
1 sibling, 0 replies; 8+ messages in thread
From: Mark Hatle @ 2011-11-30 17:51 UTC (permalink / raw)
To: openembedded-core
On 11/30/11 11:38 AM, Richard Purdie wrote:
> On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
>> This fixes startup issues like this:
>>
>> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
>> (process:91): WARNING **: Couldn't create log
>> file /var/log/ConsoleKit/history (No such file or directory)
>>
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>> .../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> index 562dfb3..a02203c 100644
>> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
>> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
>> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
>>
>> -PR = "r5"
>> +PR = "r6"
>>
>> LICENSE = "GPLv2+"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
>> ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
>> "
>>
>> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>>
>> PACKAGES =+ "pam-plugin-ck-connector"
>
> Looks like this is breaking builds:
>
> | consolekit ##################################################
> | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
This is a bit of an obscure error, but what it really means is that something
created a directory called /var/log, while something else created a symlink
called /var/log. The directory owner was installed before the symlink owner..
so when the symlink was being installed cpio went "huh?!" (note: the problem
could be /var... hard to tell)
This is one of the situations that the system wide directory "fixing" in
packages.bbclass is support to resolve.
--Mark
> :(
>
> http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 17:50 ` Koen Kooi
@ 2011-11-30 20:19 ` Richard Purdie
2011-11-30 20:39 ` Koen Kooi
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2011-11-30 20:19 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On Wed, 2011-11-30 at 18:50 +0100, Koen Kooi wrote:
> Op 30 nov. 2011, om 18:38 heeft Richard Purdie het volgende geschreven:
>
> > On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
> >> This fixes startup issues like this:
> >>
> >> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
> >> (process:91): WARNING **: Couldn't create log
> >> file /var/log/ConsoleKit/history (No such file or directory)
> >>
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> .../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >> index 562dfb3..a02203c 100644
> >> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
> >> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
> >> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
> >>
> >> -PR = "r5"
> >> +PR = "r6"
> >>
> >> LICENSE = "GPLv2+"
> >> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> >> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
> >> ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
> >> "
> >>
> >> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
> >>
> >> PACKAGES =+ "pam-plugin-ck-connector"
> >
> > Looks like this is breaking builds:
> >
> > | consolekit ##################################################
> > | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
> >
> > :(
> >
> > http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
>
> I suspect that's another victim of fs-perms.txt and rpm, it seems to
> break if /var/log is a symlink in other packages. I am going to argue
> that the breakage isn't a bug in consolekit :)
I really don't care whether its a bug in consolekit or not. The point is
that builds that were working before this change are now broken and we
have a regression.
Who is going to fix the regression?
Someone told me the answer is easy, I just revert the appropriate patch.
I tend to take on a lot of these types of issues and silently fix them
but I really need some help with it...
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 20:19 ` Richard Purdie
@ 2011-11-30 20:39 ` Koen Kooi
2011-11-30 22:57 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Koen Kooi @ 2011-11-30 20:39 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 3232 bytes --]
Op 30 nov. 2011, om 21:19 heeft Richard Purdie het volgende geschreven:
> On Wed, 2011-11-30 at 18:50 +0100, Koen Kooi wrote:
>> Op 30 nov. 2011, om 18:38 heeft Richard Purdie het volgende geschreven:
>>
>>> On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
>>>> This fixes startup issues like this:
>>>>
>>>> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
>>>> (process:91): WARNING **: Couldn't create log
>>>> file /var/log/ConsoleKit/history (No such file or directory)
>>>>
>>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>>>> ---
>>>> .../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
>>>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>>>> index 562dfb3..a02203c 100644
>>>> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>>>> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>>>> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
>>>> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
>>>> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
>>>>
>>>> -PR = "r5"
>>>> +PR = "r6"
>>>>
>>>> LICENSE = "GPLv2+"
>>>> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>>>> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
>>>> ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
>>>> "
>>>>
>>>> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>>>> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
>>>> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
>>>>
>>>> PACKAGES =+ "pam-plugin-ck-connector"
>>>
>>> Looks like this is breaking builds:
>>>
>>> | consolekit ##################################################
>>> | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
>>>
>>> :(
>>>
>>> http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
>>
>> I suspect that's another victim of fs-perms.txt and rpm, it seems to
>> break if /var/log is a symlink in other packages. I am going to argue
>> that the breakage isn't a bug in consolekit :)
>
> I really don't care whether its a bug in consolekit or not. The point is
> that builds that were working before this change are now broken and we
> have a regression.
>
> Who is going to fix the regression?
>
> Someone told me the answer is easy, I just revert the appropriate patch.
> I tend to take on a lot of these types of issues and silently fix them
> but I really need some help with it...
What I did for angstrom a while ago is to use a custom fsperms.txt that stays out of /var. That's why I'm not seeing this bug :)
regards,
Koen
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] consolekit: package /var/log/Consolekit
2011-11-30 20:39 ` Koen Kooi
@ 2011-11-30 22:57 ` Richard Purdie
0 siblings, 0 replies; 8+ messages in thread
From: Richard Purdie @ 2011-11-30 22:57 UTC (permalink / raw)
To: Koen Kooi; +Cc: Patches and discussions about the oe-core layer
On Wed, 2011-11-30 at 21:39 +0100, Koen Kooi wrote:
> Op 30 nov. 2011, om 21:19 heeft Richard Purdie het volgende geschreven:
>
> > On Wed, 2011-11-30 at 18:50 +0100, Koen Kooi wrote:
> >> Op 30 nov. 2011, om 18:38 heeft Richard Purdie het volgende geschreven:
> >>
> >>> On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
> >>>> This fixes startup issues like this:
> >>>>
> >>>> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
> >>>> (process:91): WARNING **: Couldn't create log
> >>>> file /var/log/ConsoleKit/history (No such file or directory)
> >>>>
> >>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >>>> ---
> >>>> .../recipes-support/consolekit/consolekit_0.4.5.bb | 4 ++--
> >>>> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >>>> index 562dfb3..a02203c 100644
> >>>> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >>>> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >>>> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
> >>>> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
> >>>> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
> >>>>
> >>>> -PR = "r5"
> >>>> +PR = "r6"
> >>>>
> >>>> LICENSE = "GPLv2+"
> >>>> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> >>>> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
> >>>> ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
> >>>> "
> >>>>
> >>>> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >>>> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >>>> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
> >>>>
> >>>> PACKAGES =+ "pam-plugin-ck-connector"
> >>>
> >>> Looks like this is breaking builds:
> >>>
> >>> | consolekit ##################################################
> >>> | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
> >>>
> >>> :(
> >>>
> >>> http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
> >>
> >> I suspect that's another victim of fs-perms.txt and rpm, it seems to
> >> break if /var/log is a symlink in other packages. I am going to argue
> >> that the breakage isn't a bug in consolekit :)
> >
> > I really don't care whether its a bug in consolekit or not. The point is
> > that builds that were working before this change are now broken and we
> > have a regression.
> >
> > Who is going to fix the regression?
> >
> > Someone told me the answer is easy, I just revert the appropriate patch.
> > I tend to take on a lot of these types of issues and silently fix them
> > but I really need some help with it...
>
> What I did for angstrom a while ago is to use a custom fsperms.txt
> that stays out of /var. That's why I'm not seeing this bug :)
I suspect the reason you're not seeing the bug is:
http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-angstrom/tree/recipes-core/base-files/base-files_3.0.14.bbappend
which then in turn needed a changed fsperms.txt.
I do have a way we can fix this which is to add:
RDEPENDS_${PN} = "base-files"
which ensures base-files sets up the directory structure first. I'm
going to push that and unbreak the builds that way rather than the
alternative which would be to revert it.
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-11-30 23:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 8:24 [PATCH] consolekit: package /var/log/Consolekit Koen Kooi
2011-11-30 15:11 ` Richard Purdie
2011-11-30 17:38 ` Richard Purdie
2011-11-30 17:50 ` Koen Kooi
2011-11-30 20:19 ` Richard Purdie
2011-11-30 20:39 ` Koen Kooi
2011-11-30 22:57 ` Richard Purdie
2011-11-30 17:51 ` Mark Hatle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox