Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][oe-core 1/4] sysstat: don't run populate-volatile.sh update in do_rootfs or without populate-volatile.sh
Date: Thu, 01 Dec 2011 12:18:09 +0000	[thread overview]
Message-ID: <1322741889.17484.115.camel@ted> (raw)
In-Reply-To: <9f1d39eb3edbde086f99f084c2e88d5e9fc21332.1322740824.git.Martin.Jansa@gmail.com>

On Thu, 2011-12-01 at 13:02 +0100, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/recipes-extended/sysstat/sysstat.inc       |    7 ++++++-
>  meta/recipes-extended/sysstat/sysstat_10.0.2.bb |    2 +-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-extended/sysstat/sysstat.inc b/meta/recipes-extended/sysstat/sysstat.inc
> index 2936f96..ca40ab5 100644
> --- a/meta/recipes-extended/sysstat/sysstat.inc
> +++ b/meta/recipes-extended/sysstat/sysstat.inc
> @@ -22,7 +22,12 @@ do_install() {
>  }
>  
>  pkg_postinst_${PN} () {
> -        /etc/init.d/populate-volatile.sh update
> +        if [ -n "$D" ]; then
> +                exit 1
> +        fi

I'm confused. Can't we exit 0 here since the system will have run
populate-volatile.sh update at rootfs time or first boot as needed so we
don't need to run it again?

See recipes-core/dbus/dbus.inc or pulseaudio for similar examples.

Cheers,

Richard





  reply	other threads:[~2011-12-01 12:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 12:01 [PATCH][oe-core 0/4] Small fixes for sysstat, shadow, coreutils, gconf Martin Jansa
2011-12-01 12:02 ` [PATCH][oe-core 1/4] sysstat: don't run populate-volatile.sh update in do_rootfs or without populate-volatile.sh Martin Jansa
2011-12-01 12:18   ` Richard Purdie [this message]
2011-12-01 12:41     ` Martin Jansa
2011-12-02  0:24       ` Martin Jansa
2011-12-01 12:02 ` [PATCH][oe-core 2/4] gconf: add polkit to DEPENDS only for target recipe and disable default-service for native Martin Jansa
2011-12-01 12:02 ` [PATCH][oe-core 3/4] shadow: use u-a for /usr/bin/groups Martin Jansa
2011-12-01 12:02 ` [PATCH][oe-core 4/4] coreutils: fix u-a for base64, mktemp and df Martin Jansa
2011-12-01 12:20 ` [PATCH][oe-core 0/4] Small fixes for sysstat, shadow, coreutils, gconf Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322741889.17484.115.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox