Re: [PATCH][oe-core 1/4] sysstat: don't run populate-volatile.sh update in do_rootfs or without populate-volatile.sh

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

On Thu, Dec 01, 2011 at 12:18:09PM +0000, Richard Purdie wrote:
> On Thu, 2011-12-01 at 13:02 +0100, Martin Jansa wrote:
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > ---
> >  meta/recipes-extended/sysstat/sysstat.inc       |    7 ++++++-
> >  meta/recipes-extended/sysstat/sysstat_10.0.2.bb |    2 +-
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-extended/sysstat/sysstat.inc b/meta/recipes-extended/sysstat/sysstat.inc
> > index 2936f96..ca40ab5 100644
> > --- a/meta/recipes-extended/sysstat/sysstat.inc
> > +++ b/meta/recipes-extended/sysstat/sysstat.inc
> > @@ -22,7 +22,12 @@ do_install() {
> >  }
> >  
> >  pkg_postinst_${PN} () {
> > -        /etc/init.d/populate-volatile.sh update
> > +        if [ -n "$D" ]; then
> > +                exit 1
> > +        fi
> 
> I'm confused. Can't we exit 0 here since the system will have run
> populate-volatile.sh update at rootfs time or first boot as needed so we
> don't need to run it again?
> 
> See recipes-core/dbus/dbus.inc or pulseaudio for similar examples.

Ah I didn't know about importance of return value in this case and I was
looking at 
meta/classes/module.bbclass
meta/recipes-connectivity/avahi/avahi.inc
for similar examples.

I'll learn how it's changing behavior and why avahi has exit 1 in 2/3
and exit 0 in 1/3 postinst and then I'll send updated patch if needed,
but now I'm 5 hours late to daywork.. :).

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]