* [PATCH] connman: avoid checking for linux/if_alg.h header
@ 2011-12-09 20:01 Otavio Salvador
2011-12-09 20:14 ` Khem Raj
2011-12-10 0:04 ` Richard Purdie
0 siblings, 2 replies; 6+ messages in thread
From: Otavio Salvador @ 2011-12-09 20:01 UTC (permalink / raw)
To: openembedded-core
Disable building of 'alg-test' and checking for if_alg.h header.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
meta/recipes-connectivity/connman/connman.inc | 8 ++++++++
meta/recipes-connectivity/connman/connman_0.78.bb | 2 +-
2 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index d695fee..503bf1c 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -49,6 +49,14 @@ USERADD_PARAM_${PN} = "--system --no-create-home \
inherit autotools pkgconfig update-rc.d useradd
+# alg-test doesn't build, so disable that and test
+# for if_alg.h as this header is only in 2.6.39
+do_configure_prepend() {
+ sed -i 's:tools/alg-test ::g' Makefile.am
+ sed -i 's:AC_CHECK_HEADERS(linux/if_alg.h, dummy=yes,::g;
+ s:AC_MSG_ERROR(User-space algorithm header files are required))::g' configure.ac
+}
+
do_compile_append() {
sed -i -e s:deny:allow:g src/connman-dbus.conf
}
diff --git a/meta/recipes-connectivity/connman/connman_0.78.bb b/meta/recipes-connectivity/connman/connman_0.78.bb
index 5ea2bb7..378bd9d 100644
--- a/meta/recipes-connectivity/connman/connman_0.78.bb
+++ b/meta/recipes-connectivity/connman/connman_0.78.bb
@@ -1,6 +1,6 @@
require connman.inc
-PR = "r2"
+PR = "r3"
# 0.78 tag
SRCREV = "02f5d5fe2d7c71514a6387ba2b772b42d8e8d297"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] connman: avoid checking for linux/if_alg.h header
2011-12-09 20:01 [PATCH] connman: avoid checking for linux/if_alg.h header Otavio Salvador
@ 2011-12-09 20:14 ` Khem Raj
2011-12-09 20:19 ` Otavio Salvador
2011-12-10 0:04 ` Richard Purdie
1 sibling, 1 reply; 6+ messages in thread
From: Khem Raj @ 2011-12-09 20:14 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, Dec 9, 2011 at 12:01 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> +# alg-test doesn't build, so disable that and test
> +# for if_alg.h as this header is only in 2.6.39
> +do_configure_prepend() {
> + sed -i 's:tools/alg-test ::g' Makefile.am
> + sed -i 's:AC_CHECK_HEADERS(linux/if_alg.h, dummy=yes,::g;
> + s:AC_MSG_ERROR(User-space algorithm header files are required))::g' configure.ac
> +}
> +
may be you can cache that in site files instead of this.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] connman: avoid checking for linux/if_alg.h header
2011-12-09 20:14 ` Khem Raj
@ 2011-12-09 20:19 ` Otavio Salvador
2011-12-09 20:23 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2011-12-09 20:19 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 982 bytes --]
On Fri, Dec 9, 2011 at 18:14, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Dec 9, 2011 at 12:01 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > +# alg-test doesn't build, so disable that and test
> > +# for if_alg.h as this header is only in 2.6.39
> > +do_configure_prepend() {
> > + sed -i 's:tools/alg-test ::g' Makefile.am
> > + sed -i 's:AC_CHECK_HEADERS(linux/if_alg.h, dummy=yes,::g;
> > + s:AC_MSG_ERROR(User-space algorithm header files are
> required))::g' configure.ac
> > +}
> > +
>
> may be you can cache that in site files instead of this.
>
I'm willing to try to drop this in a next patch but I'd prefer this to get
in before and get connman in a working shape again before focusing on
improvements for it.
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
[-- Attachment #2: Type: text/html, Size: 1622 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] connman: avoid checking for linux/if_alg.h header
2011-12-09 20:19 ` Otavio Salvador
@ 2011-12-09 20:23 ` Khem Raj
2011-12-09 20:30 ` Otavio Salvador
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2011-12-09 20:23 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, Dec 9, 2011 at 12:19 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, Dec 9, 2011 at 18:14, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Fri, Dec 9, 2011 at 12:01 PM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>> > +# alg-test doesn't build, so disable that and test
>> > +# for if_alg.h as this header is only in 2.6.39
>> > +do_configure_prepend() {
>> > + sed -i 's:tools/alg-test ::g' Makefile.am
>> > + sed -i 's:AC_CHECK_HEADERS(linux/if_alg.h, dummy=yes,::g;
>> > + s:AC_MSG_ERROR(User-space algorithm header files are
>> > required))::g' configure.ac
>> > +}
>> > +
>>
>> may be you can cache that in site files instead of this.
>
>
> I'm willing to try to drop this in a next patch but I'd prefer this to get
> in before and get connman in a working shape again before focusing on
> improvements for it.
your patch is already available for who are in hurry.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] connman: avoid checking for linux/if_alg.h header
2011-12-09 20:01 [PATCH] connman: avoid checking for linux/if_alg.h header Otavio Salvador
2011-12-09 20:14 ` Khem Raj
@ 2011-12-10 0:04 ` Richard Purdie
1 sibling, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2011-12-10 0:04 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, 2011-12-09 at 20:01 +0000, Otavio Salvador wrote:
> Disable building of 'alg-test' and checking for if_alg.h header.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> meta/recipes-connectivity/connman/connman.inc | 8 ++++++++
> meta/recipes-connectivity/connman/connman_0.78.bb | 2 +-
> 2 files changed, 9 insertions(+), 1 deletions(-)
Merged to master, thanks.
Longer term I think we need to check into this failure more but for now
it will get people's builds working again which is good.
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-10 0:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-09 20:01 [PATCH] connman: avoid checking for linux/if_alg.h header Otavio Salvador
2011-12-09 20:14 ` Khem Raj
2011-12-09 20:19 ` Otavio Salvador
2011-12-09 20:23 ` Khem Raj
2011-12-09 20:30 ` Otavio Salvador
2011-12-10 0:04 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox