Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: Allow do_compile_kernelmodules to use PARALLEL_MAKE
Date: Mon, 12 Dec 2011 21:30:09 +0000	[thread overview]
Message-ID: <1323725409.2731.14.camel@ted> (raw)
In-Reply-To: <1323714076.24417.100.camel@phil-desktop>

On Mon, 2011-12-12 at 18:21 +0000, Phil Blundell wrote:
> On Sat, 2011-12-10 at 15:28 -0800, Khem Raj wrote:
> > in base.bbclass oe_runmake says
> > 
> > ${MAKE} ${EXTRA_OEMAKE} "$@"
> > 
> > and
> > 
> > conf/bitbake.conf says
> > 
> > EXTRA_OEMAKE_prepend_task-compile = "${PARALLEL_MAKE} "
> > 
> > hmmm so we dont parallel make if task is not called do_compile ?
> 
> Indeed.  It's been that way basically forever; I think this was to avoid
> a class of problems caused by trying to run "make install" with -j.  
> 
> It's possible that the general situation has improved a bit since that
> code was written and it might be interesting to try enabling it for
> install as well and see what happens.

I recently merged patches to default to add PARALLEL_MAKE to do_install.
We have had surprisingly few issues with that. I think autotools itself
got fixed and hence so did anything using it. I guess anything with
broken makefiles already disables PARALLEL_MAKE so it seemed to work
pretty well.

Cheers,

Richard




      parent reply	other threads:[~2011-12-12 21:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-10  0:34 [PATCH] kernel.bbclass: Allow do_compile_kernelmodules to use PARALLEL_MAKE Richard Purdie
2011-12-10  0:36 ` Bruce Ashfield
2011-12-10  1:06 ` Darren Hart
2011-12-10 23:28 ` Khem Raj
2011-12-11  8:56   ` Koen Kooi
2011-12-12 18:21   ` Phil Blundell
2011-12-12 18:31     ` Khem Raj
2011-12-12 21:30     ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323725409.2731.14.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox