Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 2/2] dosfstools: Remove initial directory contents feature
Date: Fri, 16 Dec 2011 10:52:06 +0000	[thread overview]
Message-ID: <1324032726.4568.87.camel@ted> (raw)
In-Reply-To: <E0F4AEC8-6105-47AC-B36C-05423970FB7C@dominion.thruhere.net>

On Fri, 2011-12-16 at 08:35 +0100, Koen Kooi wrote:
> Op 16 dec. 2011, om 07:14 heeft Darren Hart het volgende geschreven:
> 
> > By using mtools, we don't need to continue to maintain and workaround
> > the issues generated by the -d feature included in the OE version of
> > mkdosfstools. This reduces the number of out-of-tree patches we have to
> > carry by 3 and eliminates a rather buggy chunk of code.
> > 
> > Drop the initial patch adding -d as well as those applied to improve it
> > and those applied to work around its deficiencies.
> 
> The meta-ti BSP layer is depending on the -b behaviour right now :(

-b behaviour is unchanged though? ;-)

Serious, can you convert to mcopy like Darren does in the patch for the
live image code? There are some seriously nasty bugs in that -d option
and since there is an easy replacement, I'm going to agree we should
drop the dosfstools patches. I'm not going to take it immediately to
give people a chance to make alternative arrangements but I do think its
going to be the best move going forwards.

Cheers,

Richard






  reply	other threads:[~2011-12-16 10:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-16  6:14 [PATCH 0/2] Drop dosfstools -d feature in favor of mtools mcopy Darren Hart
2011-12-16  6:14 ` [PATCH 1/2] bootimg: Use mcopy to construct the hddimg Darren Hart
2011-12-16 16:18   ` Richard Purdie
2011-12-16  6:14 ` [PATCH 2/2] dosfstools: Remove initial directory contents feature Darren Hart
2011-12-16  7:35   ` Koen Kooi
2011-12-16 10:52     ` Richard Purdie [this message]
2011-12-16 11:29       ` Koen Kooi
2011-12-16 15:40     ` Darren Hart
2011-12-16 15:47       ` Darren Hart
2011-12-16  6:36 ` [PATCH 0/2] Drop dosfstools -d feature in favor of mtools mcopy Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324032726.4568.87.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox