Re: [PATCH 1/2] bootimg: Use mcopy to construct the hddimg

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2011-12-15 at 22:14 -0800, Darren Hart wrote:
> The initial directory support (-d) added to mkdosfs has proven to be incomplete
> and non-compliant with FAT. Rather than continue to maintain this feature and
> work around the various issues, we can use mcopy to construct the image.
> 
> bootimg.bbclass already depends on mtools-native (although it may not have
> needed to previously). No new dependencies are introduced. The image created
> passes dosfsck cleanly. Remove the call to dosfsck.
> 
> mcopy reported an error with the image we were creating:
> Total number of sectors (107574) not a multiple of sectors per track (32)!
> 
> Add some logic to ensure the total sector count is an integral number of sectors
> per track, including forcing the logical sector size to 512 in the mkdosfs
> command.
> 
> The du -bks arguments are contradictory, -b is equivalent to "--apparent-size
> --block-size=1" and -k is --block-size=1K. If reordered, -kbs will report the
> disk usage in bytes insteadk of 1k blocks. Eliminate the ambiguity by using:
> du --apparent-size -ks
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Nitin A. Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/classes/bootimg.bbclass |   18 +++++++++++++-----
>  1 files changed, 13 insertions(+), 5 deletions(-)

Merged into master, thanks.

I'm going to hold off 2/2 to give other users a chance to migrate to
mcopy.

Cheers,

Richard