Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/2] Bug fixes
Date: Wed, 04 Jan 2012 11:22:28 +0000	[thread overview]
Message-ID: <1325676148.3555.127.camel@ted> (raw)
In-Reply-To: <4F03A2A3.80408@intel.com>

On Wed, 2012-01-04 at 08:51 +0800, Zhai, Edwin wrote:
> On 01/04/2012 07:56 AM, Saul Wold wrote:
> > On 12/29/2011 12:09 AM, edwin.zhai@intel.com wrote:
> >> From: Zhai Edwin<edwin.zhai@intel.com>
> >>
> >> All,
> >> Patch of gnome-keyring to fix gsettings-data-convert seg fault,
> >> modified according to Saul's comments.
> >> Another patch of matchbox-wm to remove the dependence between window
> >> manager and X session.
> >>
> >> The following changes since commit
> >> 6a1b5c28f22bb07a0b7102eb88441d05768ec52e:
> >>
> >> self-hosted-image: Add builder user and mini X (2011-12-29 10:42:07
> >> +0800)
> >>
> >> are available in the git repository at:
> >> git://git.pokylinux.org/poky-contrib gzhai/build-appliance2
> >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/build-appliance2
> >>
> >>
> >> Zhai Edwin (2):
> >> gnome-keyring: fix gsettings_data_convert seg fault
> >
> > Merged this one to OE-Core
> >
> >> matchbox-wm: Remove x-session-manager handling
> >>
> > We need a little more explaintion about why you are removing the U-A
> > code from the matchbox-wm?
> 
> matchbox-wm should not handles x-session, or else it conflict with 
> mini-x-session. i.e. mini-x-session set x-session to mini-X, then 
> matchbox-wm overrides it as matchbox-session. Without matchbox-session 
> installed, mini-X fail start.
> 
> I have tested this patch and found no regression...

What I don't understand is that this is using update-alternatives so
surely you can just install an alternative that overrides this?

Looking at the code, shouldn't we move this alternative to the
matchbox-session recipe?

Cheers,

Richard




  reply	other threads:[~2012-01-04 11:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29  8:09 [PATCH 0/2] Bug fixes edwin.zhai
2011-12-29  8:09 ` [PATCH 1/2] gnome-keyring: fix gsettings_data_convert seg fault edwin.zhai
2011-12-29  8:09 ` [PATCH 2/2] matchbox-wm: Remove x-session-manager handling edwin.zhai
2012-01-03 23:56 ` [PATCH 0/2] Bug fixes Saul Wold
2012-01-04  0:51   ` Zhai, Edwin
2012-01-04 11:22     ` Richard Purdie [this message]
2012-01-05  4:32       ` Zhai, Edwin
  -- strict thread matches above, loose matches on Subject: below --
2012-06-12 15:17 Laurentiu Palcu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325676148.3555.127.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox