Re: [PATCH 0/2] Bug fixes

From: "Zhai, Edwin" <edwin.zhai@intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/2] Bug fixes
Date: Thu, 5 Jan 2012 12:32:42 +0800	[thread overview]
Message-ID: <20120105043242.GB10415@edwin-gen> (raw)
In-Reply-To: <1325676148.3555.127.camel@ted>

On Wed, Jan 04, 2012 at 11:22:28AM +0000, Richard Purdie wrote:
> On Wed, 2012-01-04 at 08:51 +0800, Zhai, Edwin wrote:
> > On 01/04/2012 07:56 AM, Saul Wold wrote:
> > > On 12/29/2011 12:09 AM, edwin.zhai@intel.com wrote:
> > >> From: Zhai Edwin<edwin.zhai@intel.com>
> > >>
> > >> All,
> > >> Patch of gnome-keyring to fix gsettings-data-convert seg fault,
> > >> modified according to Saul's comments.
> > >> Another patch of matchbox-wm to remove the dependence between window
> > >> manager and X session.
> > >>
> > >> The following changes since commit
> > >> 6a1b5c28f22bb07a0b7102eb88441d05768ec52e:
> > >>
> > >> self-hosted-image: Add builder user and mini X (2011-12-29 10:42:07
> > >> +0800)
> > >>
> > >> are available in the git repository at:
> > >> git://git.pokylinux.org/poky-contrib gzhai/build-appliance2
> > >> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=gzhai/build-appliance2
> > >>
> > >>
> > >> Zhai Edwin (2):
> > >> gnome-keyring: fix gsettings_data_convert seg fault
> > >
> > > Merged this one to OE-Core
> > >
> > >> matchbox-wm: Remove x-session-manager handling
> > >>
> > > We need a little more explaintion about why you are removing the U-A
> > > code from the matchbox-wm?
> > 
> > matchbox-wm should not handles x-session, or else it conflict with 
> > mini-x-session. i.e. mini-x-session set x-session to mini-X, then 
> > matchbox-wm overrides it as matchbox-session. Without matchbox-session 
> > installed, mini-X fail start.
> > 
> > I have tested this patch and found no regression...
> 
> What I don't understand is that this is using update-alternatives so
> surely you can just install an alternative that overrides this?
> 
> Looking at the code, shouldn't we move this alternative to the
> matchbox-session recipe?

There are indential code in matchbox-session already. This patch is just 
removing duplicated code. I'll send out new patch to promote mini-x's 
alternative priority over matchbox-session.

Thanks,
Edwin

> 
> Cheers,
> 
> Richard
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
best rgds,
edwin