Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] site/common-uclibc: Cache gl_cv_func_wcwidth_works
@ 2012-01-09  4:39 Khem Raj
  2012-01-09 10:17 ` Phil Blundell
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2012-01-09  4:39 UTC (permalink / raw)
  To: openembedded-core

Its not computed properly during configure and
we configure uclibc with widechar support anyway
so its fine to cache it. It fixes the errors like

| In file included from ./stdio.h:31:0,
|                  from fpurge.h:20,
|                  from fpurge.c:20:
| /home/kraj/work/angstrom/sources/openembedded-core/build/tmp-uclibc/sysroots/qemux86/usr/include/stdio.h:662:40: error: expected declaration specifiers or '...' before '(' token
| make[4]: *** [fpurge.o] Error 1

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/site/common-uclibc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/site/common-uclibc b/meta/site/common-uclibc
index 331c2a2..c2ad42d 100644
--- a/meta/site/common-uclibc
+++ b/meta/site/common-uclibc
@@ -21,6 +21,7 @@ ac_cv_func_vsnprintf_c99=${ac_cv_func_vsnprintf_c99=yes}
 glib_cv_compliant_posix_memalign=${glib_cv_compliant_posix_memalign=1}
 glib_cv_long_long_format=${glib_cv_long_long_format=ll}
 glib_cv_have_qsort_r=${glib_cv_have_qsort_r=no}
+gl_cv_func_wcwidth_works=${gl_cv_func_wcwidth_works=yes}
 
 #dbus-glib
 ac_cv_have_abstract_sockets=${ac_cv_have_abstract_sockets=yes}
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] site/common-uclibc: Cache gl_cv_func_wcwidth_works
  2012-01-09  4:39 [PATCH] site/common-uclibc: Cache gl_cv_func_wcwidth_works Khem Raj
@ 2012-01-09 10:17 ` Phil Blundell
  2012-01-09 16:13   ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Phil Blundell @ 2012-01-09 10:17 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Sun, 2012-01-08 at 20:39 -0800, Khem Raj wrote:
> Its not computed properly during configure and
> we configure uclibc with widechar support anyway
> so its fine to cache it. It fixes the errors like

Is this really a good idea?  Wide character support is already
configurable for eglibc (via libc-posix-clang-wchar or whatever in
DISTRO_FEATURES) and it seems as though making uclibc respect that as
well would be a desirable plan for the future. 

p.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] site/common-uclibc: Cache gl_cv_func_wcwidth_works
  2012-01-09 10:17 ` Phil Blundell
@ 2012-01-09 16:13   ` Khem Raj
  0 siblings, 0 replies; 3+ messages in thread
From: Khem Raj @ 2012-01-09 16:13 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Mon, Jan 9, 2012 at 2:17 AM, Phil Blundell <philb@gnu.org> wrote:
> On Sun, 2012-01-08 at 20:39 -0800, Khem Raj wrote:
>> Its not computed properly during configure and
>> we configure uclibc with widechar support anyway
>> so its fine to cache it. It fixes the errors like
>
> Is this really a good idea?  Wide character support is already
> configurable for eglibc (via libc-posix-clang-wchar or whatever in
> DISTRO_FEATURES) and it seems as though making uclibc respect that as
> well would be a desirable plan for the future.

hmm indeed I think I should have used that instead of this.
I will redo it.

>
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-09 16:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09  4:39 [PATCH] site/common-uclibc: Cache gl_cv_func_wcwidth_works Khem Raj
2012-01-09 10:17 ` Phil Blundell
2012-01-09 16:13   ` Khem Raj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox