Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: paul.eggleton@linux.intel.com, philb@gnu.org
Subject: Re: [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v3
Date: Mon, 09 Jan 2012 18:00:33 -0600	[thread overview]
Message-ID: <1326153633.2413.10.camel@elmorro> (raw)
In-Reply-To: <CABcZAN=3CBOGDCAPHsMFd_JKLdLoK3kzX16pNt3110X32G-gqw@mail.gmail.com>

On Mon, 2012-01-09 at 16:50 -0700, Chris Larson wrote:
> On Fri, Jan 6, 2012 at 7:34 PM,  <tom.zanussi@intel.com> wrote:
> > Possible values for LICENSE_FLAGS could be:
> > - Binary - provides some kind of binary with no source
> > - Patent - provides a potential infringing item, that some may not want
> > - Commercial - include recipes that may have commercial T&C
> > - Commercial_${PN} - commercial licenses specific to ${PN}
> > - License_${PN} - include a recipe that has a specific license
> >                 - maybe similar or different than Commercial_${PN}
> 
> It's a minor gripe really, but why the capitalization here? Other
> similar variables which define lists of words to control behavior
> (e.g. MACHINE_FEATURES, DISTRO_FEATURES, IMAGE_FEATURES, and others)
> have an all-lowercase convention. I think this should behave
> similarly, for consistency.

Right, the cover letter quotes the original e-mail that does have them
with caps.  The patches themselves use all-lowercase, though.

Thanks,

Tom




  reply	other threads:[~2012-01-10  0:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07  2:34 [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v3 tom.zanussi
2012-01-07  2:34 ` [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS tom.zanussi
2012-01-07  5:10   ` Saul Wold
2012-01-07  5:13     ` Tom Zanussi
2012-01-10  0:01       ` Saul Wold
2012-01-10  0:13         ` Tom Zanussi
2012-01-12 16:56           ` Saul Wold
2012-01-07  2:34 ` [PATCH 2/5] Add LICENSE_FLAGS to packages mentioned in COMMERCIAL_LICENSE tom.zanussi
2012-01-07  2:34 ` [PATCH 3/5] base.bbclass: remove COMMERCIAL_LICENSE code tom.zanussi
2012-01-07  2:34 ` [PATCH 4/5] default-distrovars.inc: remove COMMERCIAL_LICENSE et al tom.zanussi
2012-01-07  2:34 ` [PATCH 5/5] documentation-audit.sh: remove COMMERCIAL_LICENSE warning tom.zanussi
2012-01-09 23:50 ` [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v3 Chris Larson
2012-01-10  0:00   ` Tom Zanussi [this message]
2012-01-09 23:55 ` Flanagan, Elizabeth
2012-01-10  0:07   ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326153633.2413.10.camel@elmorro \
    --to=tom.zanussi@intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=philb@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox