Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Tom Zanussi <tom.zanussi@intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS
Date: Thu, 12 Jan 2012 08:56:44 -0800	[thread overview]
Message-ID: <4F0F10CC.9030704@linux.intel.com> (raw)
In-Reply-To: <1326154410.2413.22.camel@elmorro>

On 01/09/2012 04:13 PM, Tom Zanussi wrote:
> On Mon, 2012-01-09 at 16:01 -0800, Saul Wold wrote:
>> On 01/06/2012 09:13 PM, Tom Zanussi wrote:
>>> On Fri, 2012-01-06 at 21:10 -0800, Saul Wold wrote:
>>>> On 01/06/2012 06:34 PM, tom.zanussi@intel.com wrote:
>>>>> From: Tom Zanussi<tom.zanussi@intel.com>

<SNIP>

>>>>
>> With all the discussion about License related stuff on the list and IRC,
>> I think we should be creating a bbclass to define and hold these flags.
>>    Then there is just a call from base.bbclass into check_license_flags
>> and return True/False for the skip_package().
>>
>
> So move this code into a separate .bbclass, ok.
>
Move this code the license.bbclass or meta/lib/oe/licensee.py as 
appropriate.

>> And based on a comment from Chris L. on the IRC, will this handle
>> package level LICENSE_FLAGS, this is recipe level currently, correct?
>>
>
> Right.
>
>> It could be you have some recipe with multiple binaries (for example)
>> some are OK and some are not and they are packaged separately. Can the
>> LICENSE_FLAGS handle this?
>>
>
> No, I don't think so, there's just the per-recipe LICENSE_FLAGS.  How
> would that be expanded to per-package?
>
I verified with Richard, I thought we could do per-package, we can not 
currently, so LICENSE_FLAGS will be per-recipe now.

Possibly change in the future would be per-package.

Thanks for your work on this, I you have had to do some reworks, we are 
just trying to get it right.

Sau!

> Tom
>
>> Sau!
>>
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>
>
>



  reply	other threads:[~2012-01-12 23:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-07  2:34 [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v3 tom.zanussi
2012-01-07  2:34 ` [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS tom.zanussi
2012-01-07  5:10   ` Saul Wold
2012-01-07  5:13     ` Tom Zanussi
2012-01-10  0:01       ` Saul Wold
2012-01-10  0:13         ` Tom Zanussi
2012-01-12 16:56           ` Saul Wold [this message]
2012-01-07  2:34 ` [PATCH 2/5] Add LICENSE_FLAGS to packages mentioned in COMMERCIAL_LICENSE tom.zanussi
2012-01-07  2:34 ` [PATCH 3/5] base.bbclass: remove COMMERCIAL_LICENSE code tom.zanussi
2012-01-07  2:34 ` [PATCH 4/5] default-distrovars.inc: remove COMMERCIAL_LICENSE et al tom.zanussi
2012-01-07  2:34 ` [PATCH 5/5] documentation-audit.sh: remove COMMERCIAL_LICENSE warning tom.zanussi
2012-01-09 23:50 ` [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v3 Chris Larson
2012-01-10  0:00   ` Tom Zanussi
2012-01-09 23:55 ` Flanagan, Elizabeth
2012-01-10  0:07   ` Tom Zanussi
  -- strict thread matches above, loose matches on Subject: below --
2012-01-13  5:18 [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v4 tom.zanussi
2012-01-13  5:18 ` [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS tom.zanussi
2012-01-07  2:27 [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE tom.zanussi
2012-01-07  2:27 ` [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS tom.zanussi
2012-01-06 16:45 [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE tom.zanussi
2012-01-06 16:45 ` [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS tom.zanussi
2012-01-02 19:29 [PATCH 0/5][RFC] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE tom.zanussi
2012-01-02 19:29 ` [PATCH 1/5] base.bbclass: add support for LICENSE_FLAGS tom.zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0F10CC.9030704@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=tom.zanussi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox