Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/2] gnutls fixes
@ 2012-01-17 10:57 Martin Jansa
  2012-01-17 10:58 ` [PATCH 1/2] gnutls: add readline to DEPENDS and add --with-libreadline-prefix Martin Jansa
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Martin Jansa @ 2012-01-17 10:57 UTC (permalink / raw)
  To: openembedded-core

Hi,

nobody likes when it's trying to use host's libraries and even worse 
when it succeeds and pulls them to rest of OE builds through .la files.

The following changes since commit 91e17c0c0ac2330f826b95e762542cd0d0c82385:

  pango: Use gnomebase class, not gnome (2012-01-16 18:01:31 +0000)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib jansa/gnutls
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/gnutls

Martin Jansa (2):
  gnutls: add readline to DEPENDS and add --with-libreadline-prefix
  gnutls.inc: set libz prefix

 meta/recipes-support/gnutls/gnutls.inc |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

-- 
1.7.8.3




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] gnutls: add readline to DEPENDS and add --with-libreadline-prefix
  2012-01-17 10:57 [PATCH 0/2] gnutls fixes Martin Jansa
@ 2012-01-17 10:58 ` Martin Jansa
  2012-01-17 10:58 ` [PATCH 2/2] gnutls.inc: set libz prefix Martin Jansa
  2012-01-17 15:08 ` [PATCH 0/2] gnutls fixes Richard Purdie
  2 siblings, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2012-01-17 10:58 UTC (permalink / raw)
  To: openembedded-core

* without this patch it looks for readline in host's /usr/lib
  a) and fails if readline wasn't built before gnutls, because -I is set
     and cannot find header file, this case is better
     configure:33131: checking for readline
     configure:33156: x86_64-oe-linux-gcc    -m64 --sysroot=/OE/oe-core/tmp-eglibc/sysroots/qemux86-64 -std=gnu99 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -I/OE/oe-core/tmp-eglibc/sysroots/qemux86-64/usr/include -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed conftest.c  /usr/lib/libreadline.so >&5
     conftest.c:240:31: fatal error: readline/readline.h: No such file or directory

  b) and finds usable version there if readline was built and MACHINE is compatible with host
     (like qemux86-64 on amd64 host) and then it's passing -L/usr/lib (without sysroot prefix)
     to every build using libgnutls.la
     configure:33131: checking for readline
     configure:33156: x86_64-oe-linux-gcc    -m64 --sysroot=/OE/shr-core/tmp-eglibc/sysroots/qemux86-64 -std=gnu99 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -I/OE/shr-core/tmp-eglibc/sysroots/qemux86-64/usr/include -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed conftest.c  /usr/lib/libreadline.so >&5
     configure:33156: $? = 0
     configure:33173: result: yes
     configure:33185: checking how to link with libreadline
     configure:33187: result: /usr/lib/libreadline.so
     configure:33199: checking readline/readline.h usability
     configure:33199: x86_64-oe-linux-gcc    -m64 --sysroot=/OE/shr-core/tmp-eglibc/sysroots/qemux86-64 -std=gnu99 -c -O2 -pipe -g -feliminate-unused-debug-types -I/OE/shr-core/tmp-eglibc/sysroots/qemux86-64/usr/include conftest.c >&5
     configure:33199: $? = 0
     configure:33199: result: yes
     configure:33199: checking readline/readline.h presence
     configure:33199: x86_64-oe-linux-gcc -E --sysroot=/OE/shr-core/tmp-eglibc/sysroots/qemux86-64    -m64 -I/OE/shr-core/tmp-eglibc/sysroots/qemux86-64/usr/include conftest.c
     configure:33199: $? = 0
     configure:33199: result: yes
     configure:33199: checking for readline/readline.h
     configure:33199: result: yes

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-support/gnutls/gnutls.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index cdcf85b..820faf6 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -1,7 +1,7 @@
 DESCRIPTION = "GNU Transport Layer Security Library"
 HOMEPAGE = "http://www.gnu.org/software/gnutls/"
 BUGTRACKER = "https://savannah.gnu.org/support/?group=gnutls"
-DEPENDS = "zlib lzo libtasn1 libgcrypt (>= 1.4.2) libcap"
+DEPENDS = "zlib lzo libtasn1 libgcrypt (>= 1.4.2) libcap readline"
 
 INC_PR = "r3"
 
@@ -24,6 +24,7 @@ EXTRA_OECONF="--with-included-opencdk --with-included-libcfg --disable-rpath \
               --with-libgcrypt --with-libgcrypt-prefix=${STAGING_DIR_HOST}${prefix} \
               --with-libdl-prefix=${STAGING_DIR_HOST}${prefix} \
               --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
+              --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
               --with-lzo --disable-guile \
               --without-p11-kit \
               "
-- 
1.7.8.3




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] gnutls.inc: set libz prefix
  2012-01-17 10:57 [PATCH 0/2] gnutls fixes Martin Jansa
  2012-01-17 10:58 ` [PATCH 1/2] gnutls: add readline to DEPENDS and add --with-libreadline-prefix Martin Jansa
@ 2012-01-17 10:58 ` Martin Jansa
  2012-01-17 15:08 ` [PATCH 0/2] gnutls fixes Richard Purdie
  2 siblings, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2012-01-17 10:58 UTC (permalink / raw)
  To: openembedded-core

* without this patch host's zlib is used, similar to issue with
  libreadline it's important if host's zlib is compatible with MACHINE
  and in this case zlib was in DEPENDS so header was always available in
  sysroot
  lib/config.log:
  configure:18288: checking whether to include zlib compression support
  configure:18291: result: yes
  configure:18786: checking for libz
  configure:18808: x86_64-oe-linux-gcc    -m64 --sysroot=/OE/shr-core/tmp-eglibc/sysroots/qemux86-64 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -I/OE/shr-core/tmp-eglibc/sysroots/qemux86-64/usr/include -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed conftest.c /usr/lib/libz.so  >&5
  configure:18808: $? = 0
  configure:18818: result: yes
  configure:18825: checking how to link with libz
  configure:18827: result: /usr/lib/libz.so

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/recipes-support/gnutls/gnutls.inc |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index 820faf6..5991540 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -3,7 +3,7 @@ HOMEPAGE = "http://www.gnu.org/software/gnutls/"
 BUGTRACKER = "https://savannah.gnu.org/support/?group=gnutls"
 DEPENDS = "zlib lzo libtasn1 libgcrypt (>= 1.4.2) libcap readline"
 
-INC_PR = "r3"
+INC_PR = "r4"
 
 LICENSE = "GPLv3+ & LGPLv2.1+"
 LICENSE_${PN} = "LGPLv2.1+"
@@ -25,6 +25,7 @@ EXTRA_OECONF="--with-included-opencdk --with-included-libcfg --disable-rpath \
               --with-libdl-prefix=${STAGING_DIR_HOST}${prefix} \
               --with-libpthread-prefix=${STAGING_DIR_HOST}${prefix} \
               --with-libreadline-prefix=${STAGING_DIR_HOST}${prefix} \
+              --with-libz-prefix=${STAGING_DIR_HOST}${prefix} \
               --with-lzo --disable-guile \
               --without-p11-kit \
               "
-- 
1.7.8.3




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] gnutls fixes
  2012-01-17 10:57 [PATCH 0/2] gnutls fixes Martin Jansa
  2012-01-17 10:58 ` [PATCH 1/2] gnutls: add readline to DEPENDS and add --with-libreadline-prefix Martin Jansa
  2012-01-17 10:58 ` [PATCH 2/2] gnutls.inc: set libz prefix Martin Jansa
@ 2012-01-17 15:08 ` Richard Purdie
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2012-01-17 15:08 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Tue, 2012-01-17 at 11:57 +0100, Martin Jansa wrote:
> Hi,
> 
> nobody likes when it's trying to use host's libraries and even worse 
> when it succeeds and pulls them to rest of OE builds through .la files.
> 
> The following changes since commit 91e17c0c0ac2330f826b95e762542cd0d0c82385:
> 
>   pango: Use gnomebase class, not gnome (2012-01-16 18:01:31 +0000)
> 
> are available in the git repository at:
>   git://git.openembedded.org/openembedded-core-contrib jansa/gnutls
>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=jansa/gnutls
> 
> Martin Jansa (2):
>   gnutls: add readline to DEPENDS and add --with-libreadline-prefix
>   gnutls.inc: set libz prefix

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-17 15:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 10:57 [PATCH 0/2] gnutls fixes Martin Jansa
2012-01-17 10:58 ` [PATCH 1/2] gnutls: add readline to DEPENDS and add --with-libreadline-prefix Martin Jansa
2012-01-17 10:58 ` [PATCH 2/2] gnutls.inc: set libz prefix Martin Jansa
2012-01-17 15:08 ` [PATCH 0/2] gnutls fixes Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox