From: Colin Walters <walters@verbum.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] libtool: Put all libltdl headers in the correct libltdl-dev package
Date: Tue, 17 Jan 2012 10:09:03 -0500 [thread overview]
Message-ID: <1326812944.3467.46.camel@lenny> (raw)
In-Reply-To: <4F13A366.1010807@linux.intel.com>
On Sun, 2012-01-15 at 20:11 -0800, Saul Wold wrote:
> On 01/15/2012 10:13 AM, Colin Walters wrote:
> > See attached.
> >
> >
> The current version is 2.4.2 and this requires a PR bump.
Hm, do you want a new patch that bumps the PR? What are the rules for
when a PR should be incremented?
> Also, can you use "git send-email" directly instead of sending the patch
> as an attachment, when sent that way, it requires extra steps to edit
> the file before applying.
Ah...the problem is that I'd have to teach git-send-email how to
authenticate to my mail server which isn't trivial. Would a workflow
where I paste the patch inline (thus creating whitespace damage), but
also link to my github mirror work? Let's try it with a new patch:
https://github.com/cgwalters/poky/commit/0255ac2e95bb5230f7fdf1b861be0b97b01f2ecf
From 0255ac2e95bb5230f7fdf1b861be0b97b01f2ecf Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Tue, 17 Jan 2012 09:06:28 -0500
Subject: [PATCH] zlib: Build and install zlib.pc
Poky has a fork of the zlib build system which presently installs
headers and the shared library, but neglects the zlib.pc file.
Several components (e.g. glib, WebKitGtk) look for this, so let's
provide it.
---
meta/recipes-core/zlib/files/Makefile.am | 3 +++
meta/recipes-core/zlib/files/configure.ac | 3 ++-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-core/zlib/files/Makefile.am
b/meta/recipes-core/zlib/files/Makefile.am
index b66d299..0458892 100644
--- a/meta/recipes-core/zlib/files/Makefile.am
+++ b/meta/recipes-core/zlib/files/Makefile.am
@@ -7,3 +7,6 @@ libz_la_SOURCES = adler32.c compress.c crc32.c gzlib.c
gzclose.c gzread.c \
libz_la_LDFLAGS = -version-number 1:2:5 --version-script zlib.map
include_HEADERS = zconf.h zlib.h zlibdefs.h
+
+pkgconfigdir = ${libdir}/pkgconfig
+pkgconfig_DATA = zlib.pc
diff --git a/meta/recipes-core/zlib/files/configure.ac
b/meta/recipes-core/zlib/files/configure.ac
index 4761b7e..5698175 100644
--- a/meta/recipes-core/zlib/files/configure.ac
+++ b/meta/recipes-core/zlib/files/configure.ac
@@ -43,6 +43,7 @@ cat > zlibdefs.h << EOF
#endif
EOF
-AC_CONFIG_FILES([Makefile])
+AC_CONFIG_FILES([Makefile
+ zlib.pc])
AC_OUTPUT
--
1.7.6.5
next prev parent reply other threads:[~2012-01-17 15:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 18:13 [PATCH] libtool: Put all libltdl headers in the correct libltdl-dev package Colin Walters
2012-01-16 4:11 ` Saul Wold
2012-01-17 15:09 ` Colin Walters [this message]
2012-01-17 15:15 ` Koen Kooi
2012-01-17 19:37 ` Saul Wold
2012-01-18 19:58 ` Colin Walters
2012-01-18 20:32 ` Saul Wold
2012-01-18 21:07 ` Colin Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326812944.3467.46.camel@lenny \
--to=walters@verbum.org \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox