Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Colin Walters <walters@verbum.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] libtool: Put all libltdl headers in the correct libltdl-dev package
Date: Wed, 18 Jan 2012 14:58:07 -0500	[thread overview]
Message-ID: <1326916687.24335.4.camel@lenny> (raw)
In-Reply-To: <4F15CDFD.8050204@linux.intel.com>

On Tue, 2012-01-17 at 11:37 -0800, Saul Wold wrote:

> > https://github.com/cgwalters/poky/commit/0255ac2e95bb5230f7fdf1b861be0b97b01f2ecf
> >
> Yes, this will work better in the future, let me know the github branch 
> that contains your patch against oe-core or poky master (which ever you 
> prefer).

I've uploaded all of my current patches to the "edison" branch here:
https://github.com/cgwalters/poky

There's a new one there for bash:

https://github.com/cgwalters/poky/commit/84549cb9435fe1bec38a18e1fe6daf350351cd5a

From 84549cb9435fe1bec38a18e1fe6daf350351cd5a Mon Sep 17 00:00:00 2001
From: Colin Walters <walters@verbum.org>
Date: Wed, 18 Jan 2012 14:45:21 -0500
Subject: [PATCH] bash: Ensure we use glibc getcwd(), not builtin copy

My build system runs in a chroot, and then creates bind mounts
that point outside of the chroot.  The bash implementation of getcwd()
breaks badly on this.

glibc has a perfectly working version which on modern Linux simply
invokes the getcwd() system call.  However, when cross compiling,
bash's configure script gives up, and so defers to its built in
version.

I'm not sure whether dietlibc/uclibc will malloc as bash wants, so
this patch may not be applicable everywhere.  Probably a better fix
would be for bash to detect glibc's get_current_dir_name() and use it.
---
 meta/recipes-extended/bash/bash.inc |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-extended/bash/bash.inc
b/meta/recipes-extended/bash/bash.inc
index 876be1e..f5a480a 100644
--- a/meta/recipes-extended/bash/bash.inc
+++ b/meta/recipes-extended/bash/bash.inc
@@ -14,7 +14,11 @@ PARALLEL_MAKE = ""
 bindir = "/bin"
 sbindir = "/sbin"
 
-EXTRA_OECONF = "--enable-job-control"
+# Override getcwd_malloc because the copy of getcwd()
+# in bash blows up when run inside a chroot and a bind
+# mount pointing outside.  This assumes we're using eglibc.
+EXTRA_OECONF = "--enable-job-control bash_cv_getcwd_malloc=yes "
+
 export CC_FOR_BUILD = "${BUILD_CC}"
 
 ALTERNATIVE_NAME = "sh"
-- 
1.7.6.5






  reply	other threads:[~2012-01-18 20:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 18:13 [PATCH] libtool: Put all libltdl headers in the correct libltdl-dev package Colin Walters
2012-01-16  4:11 ` Saul Wold
2012-01-17 15:09   ` Colin Walters
2012-01-17 15:15     ` Koen Kooi
2012-01-17 19:37     ` Saul Wold
2012-01-18 19:58       ` Colin Walters [this message]
2012-01-18 20:32         ` Saul Wold
2012-01-18 21:07           ` Colin Walters

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326916687.24335.4.camel@lenny \
    --to=walters@verbum.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox