Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] Bug 1834 rspro lacks the hardware for usbgadget defined in machine.conf
@ 2012-01-20  7:21 Zumeng Chen
  2012-01-20  7:21 ` [PATCH 1/1] rspro-conf: remove usbgadget from routerstationpro Zumeng Chen
  0 siblings, 1 reply; 4+ messages in thread
From: Zumeng Chen @ 2012-01-20  7:21 UTC (permalink / raw)
  To: openembedded-core

Hi Saul,

It seems usbgadget should not be supported by routerstationpro, we have to
remove it from feature matrix due to the following reasons:
  1 ) No mass storage needed to be accessed by usbgadget.
  2 ) This is routerstation+switch, so it should not be taken as a USBNET too.

This fix has been acked by Bruce, which I forgot to send out the patch,
Appologized for that Bruce and Saul.

Thanks,
Zumeng

The following changes since commit 967de59f35acef7fb258524973473f3d154e4a37:

  buildhistory_analysis: include related fields in output (2012-01-19 14:59:23 +0000)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib zumeng/rspro-conf
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zumeng/rspro-conf

Zumeng Chen (1):
  rspro-conf: remove usbgadget from routerstationpro

 meta-yocto/conf/machine/routerstationpro.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.5.4




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1] rspro-conf: remove usbgadget from routerstationpro
  2012-01-20  7:21 [PATCH 0/1] Bug 1834 rspro lacks the hardware for usbgadget defined in machine.conf Zumeng Chen
@ 2012-01-20  7:21 ` Zumeng Chen
  2012-01-20 16:32   ` Richard Purdie
  0 siblings, 1 reply; 4+ messages in thread
From: Zumeng Chen @ 2012-01-20  7:21 UTC (permalink / raw)
  To: openembedded-core

Since the target doesn't have the related requirement
to use USB slave hardware supporting usb gadget, so
remove it from MACHINE_FEATURES.

Signed-off-by: Zumeng.chen@windriver.com>
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
 meta-yocto/conf/machine/routerstationpro.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta-yocto/conf/machine/routerstationpro.conf b/meta-yocto/conf/machine/routerstationpro.conf
index 83c2f8a..a3d520d 100644
--- a/meta-yocto/conf/machine/routerstationpro.conf
+++ b/meta-yocto/conf/machine/routerstationpro.conf
@@ -5,7 +5,7 @@
 require conf/machine/include/tune-mips32.inc
 
 MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 \
-                    serial usbgadget"
+                    serial"
 
 KERNEL_IMAGETYPE = "vmlinux"
 KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] rspro-conf: remove usbgadget from routerstationpro
  2012-01-20  7:21 ` [PATCH 1/1] rspro-conf: remove usbgadget from routerstationpro Zumeng Chen
@ 2012-01-20 16:32   ` Richard Purdie
  2012-01-21  3:41     ` Zumeng Chen
  0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2012-01-20 16:32 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Fri, 2012-01-20 at 15:21 +0800, Zumeng Chen wrote:
> Since the target doesn't have the related requirement
> to use USB slave hardware supporting usb gadget, so
> remove it from MACHINE_FEATURES.
> 
> Signed-off-by: Zumeng.chen@windriver.com>
> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>  meta-yocto/conf/machine/routerstationpro.conf |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)


Merged to poky thanks. meta-yocto specific patches should really be on
the yocto list.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] rspro-conf: remove usbgadget from routerstationpro
  2012-01-20 16:32   ` Richard Purdie
@ 2012-01-21  3:41     ` Zumeng Chen
  0 siblings, 0 replies; 4+ messages in thread
From: Zumeng Chen @ 2012-01-21  3:41 UTC (permalink / raw)
  To: openembedded-core

于 2012年01月21日 00:32, Richard Purdie 写道:
> On Fri, 2012-01-20 at 15:21 +0800, Zumeng Chen wrote:
>> Since the target doesn't have the related requirement
>> to use USB slave hardware supporting usb gadget, so
>> remove it from MACHINE_FEATURES.
>>
>> Signed-off-by: Zumeng.chen@windriver.com>
>> Acked-by: Bruce Ashfield<bruce.ashfield@windriver.com>
>> ---
>>   meta-yocto/conf/machine/routerstationpro.conf |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> Merged to poky thanks. meta-yocto specific patches should really be on
> the yocto list.
Many thanks for reminder, Richard, I'll send to yocto list
next time :-)

Regards,
Zumeng
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-21  3:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-20  7:21 [PATCH 0/1] Bug 1834 rspro lacks the hardware for usbgadget defined in machine.conf Zumeng Chen
2012-01-20  7:21 ` [PATCH 1/1] rspro-conf: remove usbgadget from routerstationpro Zumeng Chen
2012-01-20 16:32   ` Richard Purdie
2012-01-21  3:41     ` Zumeng Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox