Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] gconf.bbclass: Add proper RDEPENDS to packages with gconf postinststep.
@ 2012-02-01  7:32 Koen Kooi
  2012-02-02 18:31 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Koen Kooi @ 2012-02-01  7:32 UTC (permalink / raw)
  To: openembedded-core; +Cc: Koen Kooi, Peter Tworek

From: Peter Tworek <tworaz666@gmail.com>

Right now gconf bbclass adds both postinst and prerm steps, but it does
not ensure that packages involved have gconf in RDEPENDS. This can lead
to a situation where postinst/prerm steps fail because gconftool-2 is
not installed.

Signed-off-by: Peter Tworek <tworaz666@gmail.com>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/classes/gconf.bbclass |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/meta/classes/gconf.bbclass b/meta/classes/gconf.bbclass
index c1dbbe3..7bfa871 100644
--- a/meta/classes/gconf.bbclass
+++ b/meta/classes/gconf.bbclass
@@ -56,5 +56,8 @@ python populate_packages_append () {
 				prerm = '#!/bin/sh\n'
 			prerm += d.getVar('gconf_prerm', 1)
 			d.setVar('pkg_prerm_%s' % pkg, prerm)
+			rdepends = d.getVar("RDEPENDS_%s" % pkg, True) or ""
+			rdepends += " gconf"
+			d.setVar("RDEPENDS_%s" % pkg, rdepends)
 
 }
-- 
1.7.2.5




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gconf.bbclass: Add proper RDEPENDS to packages with gconf postinststep.
  2012-02-01  7:32 [PATCH] gconf.bbclass: Add proper RDEPENDS to packages with gconf postinststep Koen Kooi
@ 2012-02-02 18:31 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2012-02-02 18:31 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi, Peter Tworek

On Wed, 2012-02-01 at 08:32 +0100, Koen Kooi wrote:
> From: Peter Tworek <tworaz666@gmail.com>
> 
> Right now gconf bbclass adds both postinst and prerm steps, but it does
> not ensure that packages involved have gconf in RDEPENDS. This can lead
> to a situation where postinst/prerm steps fail because gconftool-2 is
> not installed.
> 
> Signed-off-by: Peter Tworek <tworaz666@gmail.com>
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/classes/gconf.bbclass |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-02-02 18:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-01  7:32 [PATCH] gconf.bbclass: Add proper RDEPENDS to packages with gconf postinststep Koen Kooi
2012-02-02 18:31 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox