[PATCH 0/1] More quoting fixes

[PATCH 0/1] More quoting fixes

[Paul Eggleton]

The following changes since commit 3cb519598d9ce044ccccb2d6a52a3c0933433501:

  tcl 8.5.11: fix packaging for native version (2012-02-28 13:33:22 +0000)

are available in the git repository at:
  git://git.openembedded.org/openembedded-core-contrib paule/quoting-fixes
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/quoting-fixes

Paul Eggleton (1):
  More quoting fixes

 .../opensync/libsyncml_0.5.4.bb                    |    2 +-
 meta/recipes-devtools/guile/guile_2.0.3.bb         |    2 +-
 meta/recipes-graphics/cairo/cairo.inc              |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
1.7.5.4

[PATCH 1/1] More quoting fixes

[Paul Eggleton]

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 .../opensync/libsyncml_0.5.4.bb                    |    2 +-
 meta/recipes-devtools/guile/guile_2.0.3.bb         |    2 +-
 meta/recipes-graphics/cairo/cairo.inc              |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb b/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb
index c045698..e96463b 100644
--- a/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb
+++ b/meta-demoapps/recipes-connectivity/opensync/libsyncml_0.5.4.bb
@@ -14,4 +14,4 @@ PACKAGES += "${PN}-tools"
 FILES_${PN}-tools = "${bindir}"
 FILES_${PN} = "${libdir}/*.so.*"
 
-export VERBOSE=1
+export VERBOSE="1"
diff --git a/meta/recipes-devtools/guile/guile_2.0.3.bb b/meta/recipes-devtools/guile/guile_2.0.3.bb
index 729aed0..538ff46 100644
--- a/meta/recipes-devtools/guile/guile_2.0.3.bb
+++ b/meta/recipes-devtools/guile/guile_2.0.3.bb
@@ -39,7 +39,7 @@ do_configure_prepend() {
 	mkdir -p po
 }
 
-export GUILE_FOR_BUILD=${BUILD_SYS}-guile
+export GUILE_FOR_BUILD="${BUILD_SYS}-guile"
 
 do_compile_append() {
 	# just for target recipe
diff --git a/meta/recipes-graphics/cairo/cairo.inc b/meta/recipes-graphics/cairo/cairo.inc
index 1d5d551..69984cb 100644
--- a/meta/recipes-graphics/cairo/cairo.inc
+++ b/meta/recipes-graphics/cairo/cairo.inc
@@ -27,4 +27,4 @@ EXTRA_OECONF += "${@get_cairo_fpu_setting(bb, d)} \
 inherit autotools pkgconfig
 
 # We don't depend on binutils so we need to disable this
-export ac_cv_lib_bfd_bfd_openr=no
+export ac_cv_lib_bfd_bfd_openr="no"
-- 
1.7.5.4

Re: [PATCH 1/1] More quoting fixes

[Otavio Salvador]

On Wed, Feb 29, 2012 at 09:59, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> -export VERBOSE=1
> +export VERBOSE="1"

I fully agree with the change but here it doesn't raise a parser
error. Isn't it expected to happen?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [PATCH 1/1] More quoting fixes

[Paul Eggleton]

On Wednesday 29 February 2012 10:19:33 Otavio Salvador wrote:
> On Wed, Feb 29, 2012 at 09:59, Paul Eggleton
> 
> <paul.eggleton@linux.intel.com> wrote:
> > -export VERBOSE=1
> > +export VERBOSE="1"
> 
> I fully agree with the change but here it doesn't raise a parser
> error. Isn't it expected to happen?

Yes, that has also been fixed in bitbake master.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] More quoting fixes

[Richard Purdie]

On Wed, 2012-02-29 at 10:19 -0300, Otavio Salvador wrote:
> On Wed, Feb 29, 2012 at 09:59, Paul Eggleton
> <paul.eggleton@linux.intel.com> wrote:
> > -export VERBOSE=1
> > +export VERBOSE="1"
> 
> I fully agree with the change but here it doesn't raise a parser
> error. Isn't it expected to happen?

No. I added something to bitbake a short while ago and these are parser
errors now!

Cheers,

Richard

Re: [PATCH 1/1] More quoting fixes

[Otavio Salvador]

On Wed, Feb 29, 2012 at 10:26, Richard Purdie <rpurdie@rpsys.net> wrote:
> No. I added something to bitbake a short while ago and these are parser
> errors now!

Good.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [PATCH 0/1] More quoting fixes

[Richard Purdie]

On Wed, 2012-02-29 at 12:59 +0000, Paul Eggleton wrote:
> The following changes since commit 3cb519598d9ce044ccccb2d6a52a3c0933433501:
> 
>   tcl 8.5.11: fix packaging for native version (2012-02-28 13:33:22 +0000)
> 
> are available in the git repository at:
>   git://git.openembedded.org/openembedded-core-contrib paule/quoting-fixes
>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/quoting-fixes
> 
> Paul Eggleton (1):
>   More quoting fixes

Merged to master, thanks.

Richard