Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH v2 0/2] Fix /etc/timestamp handling
@ 2012-03-01 17:41 Gary Thomas
  2012-03-01 17:41 ` [PATCH v2 1/2] initscripts: Properly format date when set from timestamp Gary Thomas
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Gary Thomas @ 2012-03-01 17:41 UTC (permalink / raw)
  To: openembedded-core

Recent changes have attempted to make consistant use of /etc/timestamp
In particular
  5aab665 initscripts: Make /etc/timestamp consistent again.
  173a48f image.bbclass: Ensure timestamp matches format used in initscripts after recent changes
  e32e236 busybox: Enable 64 bit shell tests, and disable non-standard date format interpretation.

However, this format of the timestamp is not directly compatible with
the 'date' command line, so it must be reformatted for use.  Also,
the busybox CONFIG_FEATURE_DATE_COMPAT needs to be enabled so that all 
versions of 'date', whether from busybox or coreutils, agree on the format 
when setting the date from the command line.

Gary Thomas (2):
  initscripts: Properly format date when set from timestamp
  busybox: Restore 'date' compatability

 meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
 meta/recipes-core/busybox/busybox_1.19.3.bb        |    2 +-
 .../initscripts/initscripts-1.0/bootmisc.sh        |    2 +-
 meta/recipes-core/initscripts/initscripts_1.0.bb   |    2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
1.7.7.6




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 1/2] initscripts: Properly format date when set from timestamp
  2012-03-01 17:41 [PATCH v2 0/2] Fix /etc/timestamp handling Gary Thomas
@ 2012-03-01 17:41 ` Gary Thomas
  2012-03-01 17:41 ` [PATCH v2 2/2] busybox: Restore 'date' compatability Gary Thomas
  2012-03-01 23:15 ` [PATCH v2 0/2] Fix /etc/timestamp handling Richard Purdie
  2 siblings, 0 replies; 4+ messages in thread
From: Gary Thomas @ 2012-03-01 17:41 UTC (permalink / raw)
  To: openembedded-core

Reformat date, as stored in /etc/timestamp, to match CLI format.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 .../initscripts/initscripts-1.0/bootmisc.sh        |    2 +-
 meta/recipes-core/initscripts/initscripts_1.0.bb   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
index 20ec0a0..5b86e79 100755
--- a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
+++ b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
@@ -71,7 +71,7 @@ then
 	SYSTEMDATE=`date -u +%4Y%2m%2d%2H%2M`
 	read TIMESTAMP < /etc/timestamp
 	if [ ${TIMESTAMP} -gt $SYSTEMDATE ]; then
-		date -u $TIMESTAMP
+		date -u ${TIMESTAMP#????}${TIMESTAMP%????????}
 		/etc/init.d/hwclock.sh stop
 	fi
 fi
diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index e16f19f..68701ce 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system startup initialization scrip
 SECTION = "base"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-PR = "r131"
+PR = "r132"
 
 INHIBIT_DEFAULT_DEPS = "1"
 
-- 
1.7.7.6




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2 2/2] busybox: Restore 'date' compatability
  2012-03-01 17:41 [PATCH v2 0/2] Fix /etc/timestamp handling Gary Thomas
  2012-03-01 17:41 ` [PATCH v2 1/2] initscripts: Properly format date when set from timestamp Gary Thomas
@ 2012-03-01 17:41 ` Gary Thomas
  2012-03-01 23:15 ` [PATCH v2 0/2] Fix /etc/timestamp handling Richard Purdie
  2 siblings, 0 replies; 4+ messages in thread
From: Gary Thomas @ 2012-03-01 17:41 UTC (permalink / raw)
  To: openembedded-core

Restore CONFIG_FEATURE_DATE_COMPAT so that all versions of 'date', 
whether from busybox or coreutils, agree on the format when
setting the date from the command line.

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 meta/recipes-core/busybox/busybox-1.19.3/defconfig |    2 +-
 meta/recipes-core/busybox/busybox_1.19.3.bb        |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
index ca49671..372d7b5 100644
--- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
+++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
@@ -172,7 +172,7 @@ CONFIG_CAT=y
 CONFIG_DATE=y
 # CONFIG_FEATURE_DATE_ISOFMT is not set
 # CONFIG_FEATURE_DATE_NANO is not set
-# CONFIG_FEATURE_DATE_COMPAT is not set
+CONFIG_FEATURE_DATE_COMPAT=y
 CONFIG_ID=y
 CONFIG_GROUPS=y
 CONFIG_TEST=y
diff --git a/meta/recipes-core/busybox/busybox_1.19.3.bb b/meta/recipes-core/busybox/busybox_1.19.3.bb
index 45e284f..49ac859 100644
--- a/meta/recipes-core/busybox/busybox_1.19.3.bb
+++ b/meta/recipes-core/busybox/busybox_1.19.3.bb
@@ -1,5 +1,5 @@
 require busybox.inc
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \
-- 
1.7.7.6




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/2] Fix /etc/timestamp handling
  2012-03-01 17:41 [PATCH v2 0/2] Fix /etc/timestamp handling Gary Thomas
  2012-03-01 17:41 ` [PATCH v2 1/2] initscripts: Properly format date when set from timestamp Gary Thomas
  2012-03-01 17:41 ` [PATCH v2 2/2] busybox: Restore 'date' compatability Gary Thomas
@ 2012-03-01 23:15 ` Richard Purdie
  2 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2012-03-01 23:15 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Thu, 2012-03-01 at 10:41 -0700, Gary Thomas wrote:
> Recent changes have attempted to make consistant use of /etc/timestamp
> In particular
>   5aab665 initscripts: Make /etc/timestamp consistent again.
>   173a48f image.bbclass: Ensure timestamp matches format used in initscripts after recent changes
>   e32e236 busybox: Enable 64 bit shell tests, and disable non-standard date format interpretation.
> 
> However, this format of the timestamp is not directly compatible with
> the 'date' command line, so it must be reformatted for use.  Also,
> the busybox CONFIG_FEATURE_DATE_COMPAT needs to be enabled so that all 
> versions of 'date', whether from busybox or coreutils, agree on the format 
> when setting the date from the command line.
> 
> Gary Thomas (2):
>   initscripts: Properly format date when set from timestamp
>   busybox: Restore 'date' compatability

Merged to master, thanks.

Richard




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-03-01 23:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-01 17:41 [PATCH v2 0/2] Fix /etc/timestamp handling Gary Thomas
2012-03-01 17:41 ` [PATCH v2 1/2] initscripts: Properly format date when set from timestamp Gary Thomas
2012-03-01 17:41 ` [PATCH v2 2/2] busybox: Restore 'date' compatability Gary Thomas
2012-03-01 23:15 ` [PATCH v2 0/2] Fix /etc/timestamp handling Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox