[PATCH] image_types.bbclass: fix link creation failure if the target already exists

[PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Petr Štetiar]

| ln: failed to create symbolic link `beagleboard/systemd-image-beagleboard.tar.bz2': File exists
NOTE: package systemd-image-1.0-r0: task do_rootfs: Failed

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 5b48a09..adab573 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -61,7 +61,7 @@ runimagecmd () {
         # And create the symlinks
         if [ -n "${IMAGE_LINK_NAME}" ]; then
             for type in ${subimages}; do
-                ln -s ${IMAGE_NAME}.rootfs.$type ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.$type
+                ln -fs ${IMAGE_NAME}.rootfs.$type ${DEPLOY_DIR_IMAGE}/${IMAGE_LINK_NAME}.$type
             done
         fi
 }
-- 
1.7.9

Re: [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Richard Purdie]

On Wed, 2012-02-29 at 21:33 +0100, Petr Štetiar wrote:
> | ln: failed to create symbolic link `beagleboard/systemd-image-beagleboard.tar.bz2': File exists
> NOTE: package systemd-image-1.0-r0: task do_rootfs: Failed
> 
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
> ---
>  meta/classes/image_types.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Is this still necessary after the recent image_types.bbclass fixes?

Cheers,

Richard

Re: [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Andreas Müller]

On Thu, Mar 1, 2012 at 4:50 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Wed, 2012-02-29 at 21:33 +0100, Petr Štetiar wrote:
>> | ln: failed to create symbolic link `beagleboard/systemd-image-beagleboard.tar.bz2': File exists
>> NOTE: package systemd-image-1.0-r0: task do_rootfs: Failed
>>
>> Signed-off-by: Petr Štetiar <ynezz@true.cz>
>> ---
>>  meta/classes/image_types.bbclass |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> Is this still necessary after the recent image_types.bbclass fixes?
>
I pulled ~3-4 hours ago and the error persists. I don't know if it is
important for this problem but I am using opkg and get:

| ln: failed to create symbolic link
`/home/andreas/tmp/oe-core-eglibc/deploy/images/overo/xfce-base-image-overo.tar.bz2':
File exists
NOTE: package xfce-base-image-1.0-r0: task do_rootfs: Failed

Cheers

Andreas

Re: [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Richard Purdie]

On Fri, 2012-03-02 at 13:29 +0100, Andreas Müller wrote:
> On Thu, Mar 1, 2012 at 4:50 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2012-02-29 at 21:33 +0100, Petr Štetiar wrote:
> >> | ln: failed to create symbolic link `beagleboard/systemd-image-beagleboard.tar.bz2': File exists
> >> NOTE: package systemd-image-1.0-r0: task do_rootfs: Failed
> >>
> >> Signed-off-by: Petr Štetiar <ynezz@true.cz>
> >> ---
> >>  meta/classes/image_types.bbclass |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > Is this still necessary after the recent image_types.bbclass fixes?
> >
> I pulled ~3-4 hours ago and the error persists. I don't know if it is
> important for this problem but I am using opkg and get:
> 
> | ln: failed to create symbolic link
> `/home/andreas/tmp/oe-core-eglibc/deploy/images/overo/xfce-base-image-overo.tar.bz2':
> File exists
> NOTE: package xfce-base-image-1.0-r0: task do_rootfs: Failed

Could you see what the IMAGE_FSTYPES variable contains please?

(bitbake xfce-base-image -e | grep ^IMAGE_FSTYPES)

The code shouldn't be trying to create this symlink more than once so
whilst I understand the intent of the patch adding -f, I'd like to
understand the root cause of the problem to ensure there isn't some
other issue.

Cheers,

Richard

Re: [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Andreas Müller]

On Fri, Mar 2, 2012 at 1:38 PM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2012-03-02 at 13:29 +0100, Andreas Müller wrote:
>> On Thu, Mar 1, 2012 at 4:50 PM, Richard Purdie
>> <richard.purdie@linuxfoundation.org> wrote:
>> > On Wed, 2012-02-29 at 21:33 +0100, Petr Štetiar wrote:
>> >> | ln: failed to create symbolic link `beagleboard/systemd-image-beagleboard.tar.bz2': File exists
>> >> NOTE: package systemd-image-1.0-r0: task do_rootfs: Failed
>> >>
>> >> Signed-off-by: Petr Štetiar <ynezz@true.cz>
>> >> ---
>> >>  meta/classes/image_types.bbclass |    2 +-
>> >>  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > Is this still necessary after the recent image_types.bbclass fixes?
>> >
>> I pulled ~3-4 hours ago and the error persists. I don't know if it is
>> important for this problem but I am using opkg and get:
>>
>> | ln: failed to create symbolic link
>> `/home/andreas/tmp/oe-core-eglibc/deploy/images/overo/xfce-base-image-overo.tar.bz2':
>> File exists
>> NOTE: package xfce-base-image-1.0-r0: task do_rootfs: Failed
>
> Could you see what the IMAGE_FSTYPES variable contains please?
>
> (bitbake xfce-base-image -e | grep ^IMAGE_FSTYPES)
>
> The code shouldn't be trying to create this symlink more than once so
> whilst I understand the intent of the patch adding -f, I'd like to
> understand the root cause of the problem to ensure there isn't some
> other issue.
>
Agreed:

IMAGE_FSTYPES="tar.bz2 tar.bz2"

Seems a 'sum' of local.conf

IMAGE_FSTYPES = "tar.bz2"

and machine.conf

IMAGE_FSTYPES += "tar.bz2"

Andreas

Re: [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Richard Purdie]

On Fri, 2012-03-02 at 13:48 +0100, Andreas Müller wrote:
> On Fri, Mar 2, 2012 at 1:38 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2012-03-02 at 13:29 +0100, Andreas Müller wrote:
> >> On Thu, Mar 1, 2012 at 4:50 PM, Richard Purdie
> >> | ln: failed to create symbolic link
> >> `/home/andreas/tmp/oe-core-eglibc/deploy/images/overo/xfce-base-image-overo.tar.bz2':
> >> File exists
> >> NOTE: package xfce-base-image-1.0-r0: task do_rootfs: Failed
> >
> > Could you see what the IMAGE_FSTYPES variable contains please?
> >
> > (bitbake xfce-base-image -e | grep ^IMAGE_FSTYPES)
> >
> > The code shouldn't be trying to create this symlink more than once so
> > whilst I understand the intent of the patch adding -f, I'd like to
> > understand the root cause of the problem to ensure there isn't some
> > other issue.
> >
> Agreed:
> 
> IMAGE_FSTYPES="tar.bz2 tar.bz2"
> 
> Seems a 'sum' of local.conf
> 
> IMAGE_FSTYPES = "tar.bz2"
> 
> and machine.conf
> 
> IMAGE_FSTYPES += "tar.bz2"

Thanks, that helps a lot. I'd tested "tar tar" and "tar.gz tar.bz2" but
not that :). I think something like:

diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
index 681571d..1bf59a5 100644
--- a/meta/classes/image_types.bbclass
+++ b/meta/classes/image_types.bbclass
@@ -17,7 +17,8 @@ def get_imagecmds(d):
                     types.append(basetype)
                 if basetype not in cimages:
                     cimages[basetype] = []
-                cimages[basetype].append(ctype)
+                if ctype not in cimages[basetype]:
+                    cimages[basetype].append(ctype)
                 break
         if not basetype and type not in types:
             types.append(type)

should fix this? 

Cheers,

Richard

Re: [PATCH] image_types.bbclass: fix link creation failure if the target already exists

[Petr Štetiar]

Richard Purdie <richard.purdie@linuxfoundation.org> [2012-03-02 13:20:40]:

> Thanks, that helps a lot. I'd tested "tar tar" and "tar.gz tar.bz2" but
> not that :). I think something like:
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 681571d..1bf59a5 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -17,7 +17,8 @@ def get_imagecmds(d):
>                      types.append(basetype)
>                  if basetype not in cimages:
>                      cimages[basetype] = []
> -                cimages[basetype].append(ctype)
> +                if ctype not in cimages[basetype]:
> +                    cimages[basetype].append(ctype)
>                  break
>          if not basetype and type not in types:
>              types.append(type)
> 
> should fix this?

It's ok now. Thanks.

-- ynezz