Re: [PATCH] speex: fix FILES variables

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2012-03-21 at 12:08 +0100, Eric Bénard wrote:
> actually FILES_${PN} and FILES_${PN}-dev match the same files.
> these files are supposed to go into ${PN} so remove the other entry.
> 
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
>  meta/recipes-multimedia/speex/speex_1.2rc1.bb |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/speex/speex_1.2rc1.bb b/meta/recipes-multimedia/speex/speex_1.2rc1.bb
> index fe46a00..7370134 100644
> --- a/meta/recipes-multimedia/speex/speex_1.2rc1.bb
> +++ b/meta/recipes-multimedia/speex/speex_1.2rc1.bb
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=314649d8ba9dd7045dfb6683f298d0a8 \
>                      file://include/speex/speex.h;beginline=1;endline=34;md5=a68129f78d7fe66e07163f73aba143b3"
>  DEPENDS = "libogg"
>  
> -PR = "r0"
> +PR = "r1"
>  
>  SRC_URI = "http://downloads.us.xiph.org/releases/speex/speex-1.2rc1.tar.gz"
>  
> @@ -24,5 +24,4 @@ EXTRA_OECONF = " --enable-fixed-point --with-ogg-libraries=${STAGING_LIBDIR} \
>  
>  PACKAGES += "${PN}-bin"
>  FILES_${PN} = "${libdir}/lib*.so.*"
> -FILES_${PN}-dev += "${libdir}/lib*.so.*"
>  FILES_${PN}-bin = "${bindir}"

Doesn't this mean -dev files are ending up in the main package?

Shouldn't this be:

FILES_${PN} = "${libdir}/lib*${SOLIBS}"
FILES_${PN}-dev = "${libdir}/lib*${SOLIBSDEV}"

or better, remove these and add:

inherit lib_package

?

Cheers,

Richard