Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] speex: fix FILES variables
Date: Wed, 21 Mar 2012 13:56:36 +0100	[thread overview]
Message-ID: <20120321135636.16995ebc@eb-e6520> (raw)
In-Reply-To: <1332332772.9740.146.camel@ted>

Le Wed, 21 Mar 2012 12:26:12 +0000,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :

> On Wed, 2012-03-21 at 12:08 +0100, Eric Bénard wrote:
> > @@ -24,5 +24,4 @@ EXTRA_OECONF = " --enable-fixed-point --with-ogg-libraries=${STAGING_LIBDIR} \
> >  
> >  PACKAGES += "${PN}-bin"
> >  FILES_${PN} = "${libdir}/lib*.so.*"
> > -FILES_${PN}-dev += "${libdir}/lib*.so.*"
> >  FILES_${PN}-bin = "${bindir}"
> 
> Doesn't this mean -dev files are ending up in the main package?
> 
this seems to work fine as this (with no other layer than oe-core).

packages-split/speex
`-- usr
    `-- lib
        |-- libspeexdsp.so.1 -> libspeexdsp.so.1.5.0
        |-- libspeexdsp.so.1.5.0
        |-- libspeex.so.1 -> libspeex.so.1.5.0
        `-- libspeex.so.1.5.0

2 directories, 4 files

packages-split/speex-dev/
.../...
    |-- lib
    |   |-- libspeexdsp.la
    |   |-- libspeexdsp.so -> libspeexdsp.so.1.5.0
    |   |-- libspeex.la
    |   |-- libspeex.so -> libspeex.so.1.5.0
    |   `-- pkgconfig
    |       |-- speexdsp.pc
    |       `-- speex.pc
.../...

> Shouldn't this be:
> 
> FILES_${PN} = "${libdir}/lib*${SOLIBS}"
> FILES_${PN}-dev = "${libdir}/lib*${SOLIBSDEV}"
> 
> or better, remove these and add:
> 
> inherit lib_package
> 
> ?
> 
no clear idea on that, you are the boss to tell me which one you
prefer ;-)

Eric
-- 
http://eukrea.com/en/news/104-2012



  reply	other threads:[~2012-03-21 13:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 11:08 [PATCH] speex: fix FILES variables Eric Bénard
2012-03-21 12:26 ` Richard Purdie
2012-03-21 12:56   ` Eric Bénard [this message]
2012-03-21 14:01     ` Richard Purdie
2012-04-03 20:50 ` Saul Wold
2012-04-04  8:29   ` Eric Bénard
2012-04-04  8:41     ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120321135636.16995ebc@eb-e6520 \
    --to=eric@eukrea.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox