From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] kernel.bbclass: unify white spaces
Date: Thu, 29 Mar 2012 11:05:47 +0100 [thread overview]
Message-ID: <1333015547.14983.11.camel@ted> (raw)
In-Reply-To: <49e5bc38bdd5b01d3fb35b4d26a2d189ad2c2c44.1333001415.git.Martin.Jansa@gmail.com>
On Thu, 2012-03-29 at 08:24 +0200, Martin Jansa wrote:
> * indentation was with spaces and tabs, unify to use tabs instead of
> spaces, because "python populate_packages" expects tabs (or 8 spaces)
> and we're doing populate_packages_preppend here
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
> meta/classes/kernel.bbclass | 38 +++++++++++++++++++-------------------
> 1 files changed, 19 insertions(+), 19 deletions(-)
FWIW, we're supposed to be using tabs for shell code and spaces (4) for
python. Unfortunately populate_package() is special due to the number of
places we append/prepend it and the need to be consistent with
whitespace.
I'm therefore not sure it makes sense to re-indent the anonymous python.
Cheers,
Richard
next prev parent reply other threads:[~2012-03-29 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 6:22 [PATCH 0/2] more kernel.bbclass updates Martin Jansa
2012-03-29 6:24 ` [PATCH 1/2] kernel.bbclass: merge uboot_mkimage improvements from meta-oe Martin Jansa
2012-03-29 12:54 ` Bruce Ashfield
2012-03-29 13:11 ` Paul Gortmaker
2012-03-29 6:24 ` [PATCH 2/2] kernel.bbclass: unify white spaces Martin Jansa
2012-03-29 10:05 ` Richard Purdie [this message]
2012-03-29 12:16 ` Martin Jansa
2012-03-29 13:02 ` Richard Purdie
2012-03-29 14:08 ` [PATCHv2 0/2] more kernel.bbclass updates Martin Jansa
2012-03-29 14:08 ` [PATCHv2 1/2] kernel.bbclass: merge uboot_mkimage improvements from meta-oe Martin Jansa
2012-03-29 14:15 ` Bruce Ashfield
2012-03-29 14:08 ` [PATCHv2 2/2] kernel.bbclass: unify white spaces Martin Jansa
2012-04-24 15:03 ` [PATCHv2 0/2] more kernel.bbclass updates Martin Jansa
2012-04-27 21:07 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1333015547.14983.11.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox