Re: [PATCH 2/2] kernel.bbclass: unify white spaces

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-03-29 at 14:16 +0200, Martin Jansa wrote:
> On Thu, Mar 29, 2012 at 11:05:47AM +0100, Richard Purdie wrote:
> > On Thu, 2012-03-29 at 08:24 +0200, Martin Jansa wrote:
> > > * indentation was with spaces and tabs, unify to use tabs instead of
> > >   spaces, because "python populate_packages" expects tabs (or 8 spaces)
> > >   and we're doing populate_packages_preppend here
> > > 
> > > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> > > ---
> > >  meta/classes/kernel.bbclass |   38 +++++++++++++++++++-------------------
> > >  1 files changed, 19 insertions(+), 19 deletions(-)
> > 
> > FWIW, we're supposed to be using tabs for shell code and spaces (4) for
> > python. Unfortunately populate_package() is special due to the number of
> > places we append/prepend it and the need to be consistent with
> > whitespace.
> > 
> > I'm therefore not sure it makes sense to re-indent the anonymous python.
> 
> Agreed, but that anonymous python used spaces and tabs in the same
> function which is ugly.

I'm fine with cleaning that up but lets continue to use tabs for shell
and spaces for python where at all possible, then we're consistent :)

Cheers,

Richard