why does "bitbake -e" check the license of a *non*-included recipe file?

why does "bitbake -e" check the license of a *non*-included recipe file?

[Robert P. J. Day]

  goofing around with "bitbake -e" and, with a clean oe-core checkout,
both of the following work:

$ bitbake -e
$ bitbake -e core-image-core

  now, just for fun, i added a trivial recipe file to that images/
directory to see what kind of error message i would get if i neglected
to include a license, so i added the rday.bb recipe file (one of the
files i was using to test assignment):

RDAY ??= "rday1"
RDAY ??= "rday2"
RDAY ?= "rday3"

then tested:

$ bitbake -e rday
Loading cache: 100% |######################################################################| ETA:  00:00:00
Loaded 1106 entries from dependency cache.
ERROR: This recipe does not have the LICENSE field set (rday)                              | ETA:  --:--:--
ERROR: Unable to parse /home/rpjday/oe/oe-core/meta/recipes-core/images/rday.bb: Exited with "1"
ERROR: Command execution failed: Exited with 1

Summary: There were 3 ERROR messages shown, returning a non-zero exit code.
$

so that's pretty much what i expected.  what i *didn't* expect was
that this would still work:

$ bitbake -e

while this would now fail:

$ bitbake -e core-image-core
Loading cache: 100% |######################################################################| ETA:  00:00:00
Loaded 1106 entries from dependency cache.
ERROR: This recipe does not have the LICENSE field set (rday)                              | ETA:  --:--:--
ERROR: Unable to parse /home/rpjday/oe/oe-core/meta/recipes-core/images/rday.bb: Exited with "1"
ERROR: Command execution failed: Exited with 1

Summary: There were 3 ERROR messages shown, returning a non-zero exit code.
$

  the recipe file "rday.bb" is not being included in any of the other
images, so why should its lack of a license file cause that kind of
problem?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: why does "bitbake -e" check the license of a *non*-included recipe file?

[Chris Larson]

On Fri, Mar 30, 2012 at 5:17 PM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> $ bitbake -e core-image-core
> Loading cache: 100% |######################################################################| ETA:  00:00:00
> Loaded 1106 entries from dependency cache.
> ERROR: This recipe does not have the LICENSE field set (rday)                              | ETA:  --:--:--
> ERROR: Unable to parse /home/rpjday/oe/oe-core/meta/recipes-core/images/rday.bb: Exited with "1"
> ERROR: Command execution failed: Exited with 1
>
> Summary: There were 3 ERROR messages shown, returning a non-zero exit code.
> $
>
>  the recipe file "rday.bb" is not being included in any of the other
> images, so why should its lack of a license file cause that kind of
> problem?

It's a parse time failure, as opposed to during execution of an actual
task, and all recipes have to be parsed to operate against any recipe.
-- 
Christopher Larson

Re: why does "bitbake -e" check the license of a *non*-included recipe file?

[Robert P. J. Day]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1530 bytes --]

On Fri, 30 Mar 2012, Chris Larson wrote:

> On Fri, Mar 30, 2012 at 5:17 PM, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > $ bitbake -e core-image-core
> > Loading cache: 100% |######################################################################| ETA:  00:00:00
> > Loaded 1106 entries from dependency cache.
> > ERROR: This recipe does not have the LICENSE field set (rday)                              | ETA:  --:--:--
> > ERROR: Unable to parse /home/rpjday/oe/oe-core/meta/recipes-core/images/rday.bb: Exited with "1"
> > ERROR: Command execution failed: Exited with 1
> >
> > Summary: There were 3 ERROR messages shown, returning a non-zero exit code.
> > $
> >
> >  the recipe file "rday.bb" is not being included in any of the other
> > images, so why should its lack of a license file cause that kind of
> > problem?
>
> It's a parse time failure, as opposed to during execution of an actual
> task, and all recipes have to be parsed to operate against any recipe.

  i suspected that was it, it just threw me the first time it
happened.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: why does "bitbake -e" check the license of a *non*-included recipe file?

[Richard Purdie]

On Fri, 2012-03-30 at 20:17 -0400, Robert P. J. Day wrote:
> goofing around with "bitbake -e" and, with a clean oe-core checkout,
> both of the following work:
> 
> $ bitbake -e
> $ bitbake -e core-image-core
> 
>   now, just for fun, i added a trivial recipe file to that images/
> directory to see what kind of error message i would get if i neglected
> to include a license, so i added the rday.bb recipe file (one of the
> files i was using to test assignment):
> 
> RDAY ??= "rday1"
> RDAY ??= "rday2"
> RDAY ?= "rday3"
> 
> then tested:
> 
> $ bitbake -e rday
> Loading cache: 100% |######################################################################| ETA:  00:00:00
> Loaded 1106 entries from dependency cache.
> ERROR: This recipe does not have the LICENSE field set (rday)                              | ETA:  --:--:--
> ERROR: Unable to parse /home/rpjday/oe/oe-core/meta/recipes-core/images/rday.bb: Exited with "1"
> ERROR: Command execution failed: Exited with 1
> 
> Summary: There were 3 ERROR messages shown, returning a non-zero exit code.
> $
> 
> so that's pretty much what i expected.  what i *didn't* expect was
> that this would still work:
> 
> $ bitbake -e

This only parses the configuration. No recipes are parsed.

> while this would now fail:
> 
> $ bitbake -e core-image-core
> Loading cache: 100% |######################################################################| ETA:  00:00:00
> Loaded 1106 entries from dependency cache.
> ERROR: This recipe does not have the LICENSE field set (rday)                              | ETA:  --:--:--
> ERROR: Unable to parse /home/rpjday/oe/oe-core/meta/recipes-core/images/rday.bb: Exited with "1"
> ERROR: Command execution failed: Exited with 1
> 
> Summary: There were 3 ERROR messages shown, returning a non-zero exit code.
> $
> 
>   the recipe file "rday.bb" is not being included in any of the other
> images, so why should its lack of a license file cause that kind of
> problem?

The license validity checks are at recipe parse time, not at execution
time.

Cheers,

Richard