Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] connman: Disable tist plugin on powerpc
@ 2012-05-07  9:52 Richard Purdie
  2012-05-07 10:03 ` Koen Kooi
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Purdie @ 2012-05-07  9:52 UTC (permalink / raw)
  To: openembedded-core

This plugin doesn't build on powerpc due to powerpc's terminal ioctl defintions
being incompatible with assumptions being made by this module. Until someone has
need and can test this on powerpc, disabling is the safest option.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
index 8b27cfb..f2da8d9 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -20,6 +20,9 @@ DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
             ofono \
             "
 
+TIST = "--enable-tist"
+TIST_powerpc = ""
+
 EXTRA_OECONF += "\
     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
     ac_cv_path_PPPD=${sbindir}/pppd \
@@ -28,8 +31,8 @@ EXTRA_OECONF += "\
     --enable-threads \
     --enable-loopback \
     --enable-ethernet \
-    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi --enable-tist', '--disable-wifi', d)} \
-    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth --enable-tist', '--disable-bluetooth', d)} \
+    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
+    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
     --enable-dnsproxy \
     --enable-ofono \
     --enable-tools \





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] connman: Disable tist plugin on powerpc
  2012-05-07  9:52 [PATCH] connman: Disable tist plugin on powerpc Richard Purdie
@ 2012-05-07 10:03 ` Koen Kooi
  0 siblings, 0 replies; 2+ messages in thread
From: Koen Kooi @ 2012-05-07 10:03 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer


Op 7 mei 2012, om 11:52 heeft Richard Purdie het volgende geschreven:

> This plugin doesn't build on powerpc due to powerpc's terminal ioctl defintions
> being incompatible with assumptions being made by this module. Until someone has
> need and can test this on powerpc, disabling is the safest option.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Acked-by: Koen Kooi <koen@circuitco.com>

> ---
> diff --git a/meta/recipes-connectivity/connman/connman.inc b/meta/recipes-connectivity/connman/connman.inc
> index 8b27cfb..f2da8d9 100644
> --- a/meta/recipes-connectivity/connman/connman.inc
> +++ b/meta/recipes-connectivity/connman/connman.inc
> @@ -20,6 +20,9 @@ DEPENDS  = "dbus glib-2.0 ppp iptables gnutls \
>             ofono \
>             "
> 
> +TIST = "--enable-tist"
> +TIST_powerpc = ""
> +
> EXTRA_OECONF += "\
>     ac_cv_path_WPASUPPLICANT=${sbindir}/wpa_supplicant \
>     ac_cv_path_PPPD=${sbindir}/pppd \
> @@ -28,8 +31,8 @@ EXTRA_OECONF += "\
>     --enable-threads \
>     --enable-loopback \
>     --enable-ethernet \
> -    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi --enable-tist', '--disable-wifi', d)} \
> -    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth --enable-tist', '--disable-bluetooth', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi ${TIST}', '--disable-wifi', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth ${TIST}', '--disable-bluetooth', d)} \
>     --enable-dnsproxy \
>     --enable-ofono \
>     --enable-tools \
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-05-07 10:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07  9:52 [PATCH] connman: Disable tist plugin on powerpc Richard Purdie
2012-05-07 10:03 ` Koen Kooi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox