Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm
@ 2012-06-09 22:19 Khem Raj
  2012-06-09 22:19 ` [PATCH 2/2] gcc-common: Replace use of TARGET_ARCH with TRANSLATED_TARGET_ARCH Khem Raj
  2012-06-11 12:50 ` [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm Richard Purdie
  0 siblings, 2 replies; 3+ messages in thread
From: Khem Raj @ 2012-06-09 22:19 UTC (permalink / raw)
  To: openembedded-core

We need to check target to be arm before enabling hard-float
ABI. There are crossdk targets or candian-cross targets built
for arm and we should not enable it for those class of recipes.

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-common.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index c479403..7911ceb 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -10,7 +10,7 @@ inherit autotools gettext
 FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
 
 def get_gcc_fpu_setting(bb, d):
-    if d.getVar('ARMPKGSFX_EABI', True) is "hf":
+    if d.getVar('ARMPKGSFX_EABI', True) is "hf" and  d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
         return "--with-float=hard"
     if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
         return "--with-float=soft"
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] gcc-common: Replace use of TARGET_ARCH with TRANSLATED_TARGET_ARCH
  2012-06-09 22:19 [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm Khem Raj
@ 2012-06-09 22:19 ` Khem Raj
  2012-06-11 12:50 ` [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Khem Raj @ 2012-06-09 22:19 UTC (permalink / raw)
  To: openembedded-core

TARGET_ARCH is poured into TRANSLATED_TARGET_ARCH
for gcc-cross family or gcc-crosssdk family
of recipes we have to check for TRANSLATED_TARGET_ARCH

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-devtools/gcc/gcc-common.inc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc
index 7911ceb..45828bb 100644
--- a/meta/recipes-devtools/gcc/gcc-common.inc
+++ b/meta/recipes-devtools/gcc/gcc-common.inc
@@ -19,12 +19,12 @@ def get_gcc_fpu_setting(bb, d):
     return ""
 
 def get_gcc_mips_plt_setting(bb, d):
-    if d.getVar('TARGET_ARCH', True) in [ 'mips', 'mipsel' ] and 'mplt' in d.getVar('DISTRO_FEATURES',1).split() :
+    if d.getVar('TRANSLATED_TARGET_ARCH', True) in [ 'mips', 'mipsel' ] and 'mplt' in d.getVar('DISTRO_FEATURES',1).split() :
         return "--with-mips-plt"
     return ""
 
 def get_gcc_multiarch_setting(bb, d):
-    target_arch = d.getVar('TARGET_ARCH', True)
+    target_arch = d.getVar('TRANSLATED_TARGET_ARCH', True)
     multiarch_options = {
         "i586":    "--enable-targets=all",
         "powerpc": "--enable-targets=powerpc64",
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm
  2012-06-09 22:19 [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm Khem Raj
  2012-06-09 22:19 ` [PATCH 2/2] gcc-common: Replace use of TARGET_ARCH with TRANSLATED_TARGET_ARCH Khem Raj
@ 2012-06-11 12:50 ` Richard Purdie
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2012-06-11 12:50 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Sat, 2012-06-09 at 15:19 -0700, Khem Raj wrote:
> We need to check target to be arm before enabling hard-float
> ABI. There are crossdk targets or candian-cross targets built
> for arm and we should not enable it for those class of recipes.
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-devtools/gcc/gcc-common.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Merged to master (along with 2/2), thanks.

Richard




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-06-11 13:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-09 22:19 [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm Khem Raj
2012-06-09 22:19 ` [PATCH 2/2] gcc-common: Replace use of TARGET_ARCH with TRANSLATED_TARGET_ARCH Khem Raj
2012-06-11 12:50 ` [PATCH 1/2] gcc-common: Enable hardfloat ABI when target is arm Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox