Re: [PATCH 2/3] busybox: Add setsid and cttyhack for tiny DISTRO_FEATURE

[Phil Blundell <philb@gnu.org>]

On Wed, 2012-06-13 at 22:19 -0700, Darren Hart wrote:
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> index 5b83d32..d07ba7e 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -57,6 +57,8 @@ def features_to_busybox_settings(d):
>  	busybox_cfg('nls',  distro_features, 'CONFIG_LOCALE_SUPPORT', cnf, rem)
>  	busybox_cfg('ipv4', distro_features, 'CONFIG_FEATURE_IFUPDOWN_IPV4', cnf, rem)
>  	busybox_cfg('ipv6', distro_features, 'CONFIG_FEATURE_IFUPDOWN_IPV6', cnf, rem)
> +	busybox_cfg('tiny', distro_features, 'CONFIG_SETSID', cnf, rem)
> +	busybox_cfg('tiny', distro_features, 'CONFIG_CTTYHACK', cnf, rem)
>  	return "\n".join(cnf), "\n".join(rem)
>  
>  # X, Y = ${@features_to_uclibc_settings(d)}

What exactly is the mission of the "tiny" DISTRO_FEATURE?  It doesn't
seem very wholesome for it to be enabling a random grab-bag of bits in
busybox (or anywhere else).  

If poky-tiny wants those features enabled then it can, and should, ship
its own configuration for busybox which turns them on.  I think that
would be better than further proliferation of switches in oe-core.

p.