Re: [PATCH 2/3] busybox: Add setsid and cttyhack for tiny DISTRO_FEATURE

[Khem Raj <raj.khem@gmail.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 6/13/2012 10:19 PM, Darren Hart wrote:
> When building very small systems, it can be useful to spawn a shell
> from a simple init script, rather than a full System V Init 
> process. This requires the shell be the session leader and be able
> to open the controlling terminal if it is to have job control.
> 
> Enable CONFIG_CTTYHACK and CONFIG_SETSID to enable this for
> distros defining the "tiny" DISTRO_FEATURE.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com> CC: OE Core
> <openembedded-core@lists.openembedded.org> --- 
> meta/recipes-core/busybox/busybox.inc |    2 ++ 1 files changed, 2
> insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-core/busybox/busybox.inc
> b/meta/recipes-core/busybox/busybox.inc index 5b83d32..d07ba7e
> 100644 --- a/meta/recipes-core/busybox/busybox.inc +++
> b/meta/recipes-core/busybox/busybox.inc @@ -57,6 +57,8 @@ def
> features_to_busybox_settings(d): busybox_cfg('nls',
> distro_features, 'CONFIG_LOCALE_SUPPORT', cnf, rem) 
> busybox_cfg('ipv4', distro_features,
> 'CONFIG_FEATURE_IFUPDOWN_IPV4', cnf, rem) busybox_cfg('ipv6',
> distro_features, 'CONFIG_FEATURE_IFUPDOWN_IPV6', cnf, rem) +
> busybox_cfg('tiny', distro_features, 'CONFIG_SETSID', cnf, rem) +
> busybox_cfg('tiny', distro_features, 'CONFIG_CTTYHACK', cnf, rem) 
> return "\n".join(cnf), "\n".join(rem)
> 
> # X, Y = ${@features_to_uclibc_settings(d)}

Enabling cttyhack and setsid could be a good thing in general
(thinking of initramfs kind of images) so I would propose to enable it
by default
and not introduce another distro knob here. How much does busybox code
size grow which these two features turned on.?

otherwise second best thing is to keep it in poky-tiny distro layer
which wants to set the policy
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/ZjTsACgkQuwUzVZGdMxSXwACfX44Ffs5G4hhW9q9toubwxZYn
Ag4AnijTe1TbzrGZfHaHw+qZY/IQAzlA
=mTVi
-----END PGP SIGNATURE-----