* [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR @ 2012-07-12 9:17 b28495 2012-07-12 9:17 ` [PATCH] linux-dtb.inc: update dtb " b28495 2012-07-12 11:02 ` [PATCH] kernel.bbclass: update image " Richard Purdie 0 siblings, 2 replies; 10+ messages in thread From: b28495 @ 2012-07-12 9:17 UTC (permalink / raw) To: openembedded-core; +Cc: b29882 From: Ting Liu <b28495@freescale.com> Signed-off-by: Ting Liu <b28495@freescale.com> --- meta/classes/kernel.bbclass | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index 81c334b..420a1ec 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -122,7 +122,12 @@ kernel_do_install() { # install -d ${D}/${KERNEL_IMAGEDEST} install -d ${D}/boot - install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION} + install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin + cd ${D}/${KERNEL_IMAGEDEST}/ + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE} + cd - install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION} install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION} install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION} -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR 2012-07-12 9:17 [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR b28495 @ 2012-07-12 9:17 ` b28495 2012-07-12 11:03 ` Richard Purdie 2012-07-12 11:02 ` [PATCH] kernel.bbclass: update image " Richard Purdie 1 sibling, 1 reply; 10+ messages in thread From: b28495 @ 2012-07-12 9:17 UTC (permalink / raw) To: openembedded-core; +Cc: b29882 From: Ting Liu <b28495@freescale.com> Device tree binary is named as "devicetree-*" in ${D}, "${KERNEL_IMAGETYPE}-*" in ${DEPLOYDIR}. Keep them the same. Signed-off-by: Ting Liu <b28495@freescale.com> --- meta/recipes-kernel/linux/linux-dtb.inc | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc index 8aa1458..3dd4d41 100644 --- a/meta/recipes-kernel/linux/linux-dtb.inc +++ b/meta/recipes-kernel/linux/linux-dtb.inc @@ -1,5 +1,5 @@ # Support for device tree generation -FILES_kernel-devicetree = "/boot/devicetree*" +FILES_kernel-devicetree = "/boot/*.dtb" KERNEL_DEVICETREE_FLAGS = "-R 8 -p 0x3000" python __anonymous () { @@ -10,7 +10,7 @@ python __anonymous () { depends = d.getVar("DEPENDS", True) d.setVar("DEPENDS", "%s dtc-native" % depends) packages = d.getVar("PACKAGES", True) - d.setVar("PACKAGES", "%s kernel-devicetree" % packages) + d.setVar("PACKAGES", "kernel-devicetree %s" % packages) } do_install_append() { @@ -24,7 +24,10 @@ do_install_append() { DTB_NAME=`echo ${KERNEL_IMAGE_BASE_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` DTB_SYMLINK_NAME=`echo ${KERNEL_IMAGE_SYMLINK_NAME} | sed "s/${MACHINE}/${DTS_BASE_NAME}/g"` dtc -I dts -O dtb ${KERNEL_DEVICETREE_FLAGS} -o ${DTS_BASE_NAME} ${DTS_FILE} - install -m 0644 ${DTS_BASE_NAME} ${D}/boot/devicetree-${DTB_SYMLINK_NAME}.dtb + install -m 0644 ${DTS_BASE_NAME} ${D}/boot/${DTB_NAME}.dtb + cd ${D}/boot/ + ln -sf ${DTB_NAME}.dtb ${DTB_SYMLINK_NAME}.dtb + cd - done fi } -- 1.7.3.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR 2012-07-12 9:17 ` [PATCH] linux-dtb.inc: update dtb " b28495 @ 2012-07-12 11:03 ` Richard Purdie 2012-07-15 11:07 ` Liu Ting-B28495 0 siblings, 1 reply; 10+ messages in thread From: Richard Purdie @ 2012-07-12 11:03 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: b29882 On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: > From: Ting Liu <b28495@freescale.com> > > Device tree binary is named as "devicetree-*" in ${D}, > "${KERNEL_IMAGETYPE}-*" in ${DEPLOYDIR}. Keep them the same. > > Signed-off-by: Ting Liu <b28495@freescale.com> > --- > meta/recipes-kernel/linux/linux-dtb.inc | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc b/meta/recipes-kernel/linux/linux-dtb.inc > index 8aa1458..3dd4d41 100644 > --- a/meta/recipes-kernel/linux/linux-dtb.inc > +++ b/meta/recipes-kernel/linux/linux-dtb.inc > @@ -1,5 +1,5 @@ > # Support for device tree generation > -FILES_kernel-devicetree = "/boot/devicetree*" > +FILES_kernel-devicetree = "/boot/*.dtb" > KERNEL_DEVICETREE_FLAGS = "-R 8 -p 0x3000" > > python __anonymous () { > @@ -10,7 +10,7 @@ python __anonymous () { > depends = d.getVar("DEPENDS", True) > d.setVar("DEPENDS", "%s dtc-native" % depends) > packages = d.getVar("PACKAGES", True) > - d.setVar("PACKAGES", "%s kernel-devicetree" % packages) > + d.setVar("PACKAGES", "kernel-devicetree %s" % packages) > } Why did you need to change PACKAGES? There is no mention of this in the patch description. Cheers, Richard ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR 2012-07-12 11:03 ` Richard Purdie @ 2012-07-15 11:07 ` Liu Ting-B28495 2012-07-16 22:23 ` McClintock Matthew-B29882 0 siblings, 1 reply; 10+ messages in thread From: Liu Ting-B28495 @ 2012-07-15 11:07 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: McClintock Matthew-B29882 -----Original Message----- From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie Sent: Thursday, July 12, 2012 7:04 PM To: Patches and discussions about the oe-core layer Cc: McClintock Matthew-B29882 Subject: Re: [OE-core] [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: > From: Ting Liu <b28495@freescale.com> > > Device tree binary is named as "devicetree-*" in ${D}, > "${KERNEL_IMAGETYPE}-*" in ${DEPLOYDIR}. Keep them the same. > > Signed-off-by: Ting Liu <b28495@freescale.com> > --- > meta/recipes-kernel/linux/linux-dtb.inc | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-kernel/linux/linux-dtb.inc > b/meta/recipes-kernel/linux/linux-dtb.inc > index 8aa1458..3dd4d41 100644 > --- a/meta/recipes-kernel/linux/linux-dtb.inc > +++ b/meta/recipes-kernel/linux/linux-dtb.inc > @@ -1,5 +1,5 @@ > # Support for device tree generation > -FILES_kernel-devicetree = "/boot/devicetree*" > +FILES_kernel-devicetree = "/boot/*.dtb" > KERNEL_DEVICETREE_FLAGS = "-R 8 -p 0x3000" > > python __anonymous () { > @@ -10,7 +10,7 @@ python __anonymous () { > depends = d.getVar("DEPENDS", True) > d.setVar("DEPENDS", "%s dtc-native" % depends) > packages = d.getVar("PACKAGES", True) > - d.setVar("PACKAGES", "%s kernel-devicetree" % packages) > + d.setVar("PACKAGES", "kernel-devicetree %s" % packages) > } Why did you need to change PACKAGES? There is no mention of this in the patch description. Cheers, Richard [Liu Ting-B28495] Sorry for missing that. Because device tree binary is renamed with prefix "${KERNEL_IMAGETYPE}, it will be packaged to kernel-image if not modifying the variable PACKAGES. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR 2012-07-15 11:07 ` Liu Ting-B28495 @ 2012-07-16 22:23 ` McClintock Matthew-B29882 0 siblings, 0 replies; 10+ messages in thread From: McClintock Matthew-B29882 @ 2012-07-16 22:23 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: McClintock Matthew-B29882 On Sun, Jul 15, 2012 at 6:07 AM, Liu Ting-B28495 <B28495@freescale.com> wrote: > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie > Sent: Thursday, July 12, 2012 7:04 PM > To: Patches and discussions about the oe-core layer > Cc: McClintock Matthew-B29882 > Subject: Re: [OE-core] [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR > > On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: >> From: Ting Liu <b28495@freescale.com> >> >> Device tree binary is named as "devicetree-*" in ${D}, >> "${KERNEL_IMAGETYPE}-*" in ${DEPLOYDIR}. Keep them the same. >> >> Signed-off-by: Ting Liu <b28495@freescale.com> >> --- >> meta/recipes-kernel/linux/linux-dtb.inc | 9 ++++++--- >> 1 files changed, 6 insertions(+), 3 deletions(-) >> >> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc >> b/meta/recipes-kernel/linux/linux-dtb.inc >> index 8aa1458..3dd4d41 100644 >> --- a/meta/recipes-kernel/linux/linux-dtb.inc >> +++ b/meta/recipes-kernel/linux/linux-dtb.inc >> @@ -1,5 +1,5 @@ >> # Support for device tree generation >> -FILES_kernel-devicetree = "/boot/devicetree*" >> +FILES_kernel-devicetree = "/boot/*.dtb" >> KERNEL_DEVICETREE_FLAGS = "-R 8 -p 0x3000" >> >> python __anonymous () { >> @@ -10,7 +10,7 @@ python __anonymous () { >> depends = d.getVar("DEPENDS", True) >> d.setVar("DEPENDS", "%s dtc-native" % depends) >> packages = d.getVar("PACKAGES", True) >> - d.setVar("PACKAGES", "%s kernel-devicetree" % packages) >> + d.setVar("PACKAGES", "kernel-devicetree %s" % packages) >> } > > Why did you need to change PACKAGES? There is no mention of this in the patch description. > > Cheers, > > Richard > > [Liu Ting-B28495] Sorry for missing that. Because device tree binary is renamed with prefix "${KERNEL_IMAGETYPE}, it will be packaged to kernel-image if not modifying the variable PACKAGES. Ok, so you reordered the packages so your device tree package get's to grab the file first. Did you consider making the other package less greedy and excluding these dtb files? Why is any of this in an anonymous python function? Should it just be DEPENDS_append PACKAGES_append ? -M ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR 2012-07-12 9:17 [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR b28495 2012-07-12 9:17 ` [PATCH] linux-dtb.inc: update dtb " b28495 @ 2012-07-12 11:02 ` Richard Purdie 2012-07-15 11:18 ` Liu Ting-B28495 1 sibling, 1 reply; 10+ messages in thread From: Richard Purdie @ 2012-07-12 11:02 UTC (permalink / raw) To: Patches and discussions about the oe-core layer; +Cc: b29882 On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: > From: Ting Liu <b28495@freescale.com> > > Signed-off-by: Ting Liu <b28495@freescale.com> > --- > meta/classes/kernel.bbclass | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index 81c334b..420a1ec 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -122,7 +122,12 @@ kernel_do_install() { > # > install -d ${D}/${KERNEL_IMAGEDEST} > install -d ${D}/boot > - install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION} > + install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin > + cd ${D}/${KERNEL_IMAGEDEST}/ > + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin > + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin > + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE} > + cd - > install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION} > install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION} > install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION} This is going to break users who rely on the existing naming/layout. The patch description is lacking on why we need to do this too, it just says what you're doing and not why. Cheers, Richard ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR 2012-07-12 11:02 ` [PATCH] kernel.bbclass: update image " Richard Purdie @ 2012-07-15 11:18 ` Liu Ting-B28495 2012-07-15 16:02 ` Khem Raj 2012-07-16 22:20 ` McClintock Matthew-B29882 0 siblings, 2 replies; 10+ messages in thread From: Liu Ting-B28495 @ 2012-07-15 11:18 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: McClintock Matthew-B29882, Luo Zhenhua-B19537 -----Original Message----- From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie Sent: Thursday, July 12, 2012 7:03 PM To: Patches and discussions about the oe-core layer Cc: McClintock Matthew-B29882 Subject: Re: [OE-core] [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: > From: Ting Liu <b28495@freescale.com> > > Signed-off-by: Ting Liu <b28495@freescale.com> > --- > meta/classes/kernel.bbclass | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index 81c334b..420a1ec 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -122,7 +122,12 @@ kernel_do_install() { > # > install -d ${D}/${KERNEL_IMAGEDEST} > install -d ${D}/boot > - install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION} > + install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin > + cd ${D}/${KERNEL_IMAGEDEST}/ > + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin > + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin > + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE} > + cd - > install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION} > install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION} > install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION} This is going to break users who rely on the existing naming/layout. The patch description is lacking on why we need to do this too, it just says what you're doing and not why. Cheers, Richard [Liu Ting-B28495] on our side, we used two ways to load the kernel images. 1) load from Ethernet 2) load from hard disk which deployed with the rootfs image containing kernel image (installing the package 'kernel-image'). We cannot use the same bootargs in u-boot due to the mismatched name. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR 2012-07-15 11:18 ` Liu Ting-B28495 @ 2012-07-15 16:02 ` Khem Raj 2012-07-17 8:30 ` Liu Ting-B28495 2012-07-16 22:20 ` McClintock Matthew-B29882 1 sibling, 1 reply; 10+ messages in thread From: Khem Raj @ 2012-07-15 16:02 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: McClintock Matthew-B29882, Luo Zhenhua-B19537 On Sun, Jul 15, 2012 at 4:18 AM, Liu Ting-B28495 <B28495@freescale.com> wrote: > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie > Sent: Thursday, July 12, 2012 7:03 PM > To: Patches and discussions about the oe-core layer > Cc: McClintock Matthew-B29882 > Subject: Re: [OE-core] [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR > > On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: >> From: Ting Liu <b28495@freescale.com> >> >> Signed-off-by: Ting Liu <b28495@freescale.com> >> --- >> meta/classes/kernel.bbclass | 7 ++++++- >> 1 files changed, 6 insertions(+), 1 deletions(-) >> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >> index 81c334b..420a1ec 100644 >> --- a/meta/classes/kernel.bbclass >> +++ b/meta/classes/kernel.bbclass >> @@ -122,7 +122,12 @@ kernel_do_install() { >> # >> install -d ${D}/${KERNEL_IMAGEDEST} >> install -d ${D}/boot >> - install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION} >> + install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin >> + cd ${D}/${KERNEL_IMAGEDEST}/ >> + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE} >> + cd - >> install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION} >> install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION} >> install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION} > > This is going to break users who rely on the existing naming/layout. > > The patch description is lacking on why we need to do this too, it just says what you're doing and not why. > > Cheers, > > Richard > > > [Liu Ting-B28495] on our side, we used two ways to load the kernel images. 1) load from Ethernet 2) load from hard disk which deployed with the rootfs image containing kernel image (installing the package 'kernel-image'). We cannot use the same bootargs in u-boot due to the mismatched name. so define two macros nfsboot and diskboot which take care of setting all required parameters as well as other env vars. > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR 2012-07-15 16:02 ` Khem Raj @ 2012-07-17 8:30 ` Liu Ting-B28495 0 siblings, 0 replies; 10+ messages in thread From: Liu Ting-B28495 @ 2012-07-17 8:30 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: McClintock Matthew-B29882, Luo Zhenhua-B19537 > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > Khem Raj > Sent: Monday, July 16, 2012 12:02 AM > To: Patches and discussions about the oe-core layer > Cc: McClintock Matthew-B29882; Luo Zhenhua-B19537 > Subject: Re: [OE-core] [PATCH] kernel.bbclass: update image name to keep > it same in D and DEPLOYDIR > > On Sun, Jul 15, 2012 at 4:18 AM, Liu Ting-B28495 <B28495@freescale.com> > wrote: > > -----Original Message----- > > From: openembedded-core-bounces@lists.openembedded.org > > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > > Richard Purdie > > Sent: Thursday, July 12, 2012 7:03 PM > > To: Patches and discussions about the oe-core layer > > Cc: McClintock Matthew-B29882 > > Subject: Re: [OE-core] [PATCH] kernel.bbclass: update image name to > > keep it same in D and DEPLOYDIR > > > > On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: > >> From: Ting Liu <b28495@freescale.com> > >> > >> Signed-off-by: Ting Liu <b28495@freescale.com> > >> --- > >> meta/classes/kernel.bbclass | 7 ++++++- > >> 1 files changed, 6 insertions(+), 1 deletions(-) > >> > >> diff --git a/meta/classes/kernel.bbclass > >> b/meta/classes/kernel.bbclass index 81c334b..420a1ec 100644 > >> --- a/meta/classes/kernel.bbclass > >> +++ b/meta/classes/kernel.bbclass > >> @@ -122,7 +122,12 @@ kernel_do_install() { > >> # > >> install -d ${D}/${KERNEL_IMAGEDEST} > >> install -d ${D}/boot > >> - install -m 0644 ${KERNEL_OUTPUT} > ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION} > >> + install -m 0644 ${KERNEL_OUTPUT} > ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin > >> + cd ${D}/${KERNEL_IMAGEDEST}/ > >> + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin > >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin > ${KERNEL_IMAGE_SYMLINK_NAME}.bin > >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE} > >> + cd - > >> install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION} > >> install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION} > >> install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION} > > > > This is going to break users who rely on the existing naming/layout. > > > > The patch description is lacking on why we need to do this too, it just > says what you're doing and not why. > > > > Cheers, > > > > Richard > > > > > > [Liu Ting-B28495] on our side, we used two ways to load the kernel > images. 1) load from Ethernet 2) load from hard disk which deployed with > the rootfs image containing kernel image (installing the package 'kernel- > image'). We cannot use the same bootargs in u-boot due to the mismatched > name. > > so define two macros nfsboot and diskboot which take care of setting all > required parameters as well as other env vars. > [Liu Ting-B28495] Maybe I made a misunderstanding here. The problem is that: for the same kernel image, the one get deployed has a name, and the one contained in rootfs has another name. It will be helpful if we can unify them. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR 2012-07-15 11:18 ` Liu Ting-B28495 2012-07-15 16:02 ` Khem Raj @ 2012-07-16 22:20 ` McClintock Matthew-B29882 1 sibling, 0 replies; 10+ messages in thread From: McClintock Matthew-B29882 @ 2012-07-16 22:20 UTC (permalink / raw) To: Patches and discussions about the oe-core layer Cc: McClintock Matthew-B29882, Luo Zhenhua-B19537 On Sun, Jul 15, 2012 at 6:18 AM, Liu Ting-B28495 <B28495@freescale.com> wrote: > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie > Sent: Thursday, July 12, 2012 7:03 PM > To: Patches and discussions about the oe-core layer > Cc: McClintock Matthew-B29882 > Subject: Re: [OE-core] [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR > > On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote: >> From: Ting Liu <b28495@freescale.com> >> >> Signed-off-by: Ting Liu <b28495@freescale.com> >> --- >> meta/classes/kernel.bbclass | 7 ++++++- >> 1 files changed, 6 insertions(+), 1 deletions(-) >> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >> index 81c334b..420a1ec 100644 >> --- a/meta/classes/kernel.bbclass >> +++ b/meta/classes/kernel.bbclass >> @@ -122,7 +122,12 @@ kernel_do_install() { >> # >> install -d ${D}/${KERNEL_IMAGEDEST} >> install -d ${D}/boot >> - install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE}-${KERNEL_VERSION} >> + install -m 0644 ${KERNEL_OUTPUT} ${D}/${KERNEL_IMAGEDEST}/${KERNEL_IMAGE_BASE_NAME}.bin >> + cd ${D}/${KERNEL_IMAGEDEST}/ >> + rm -f ${KERNEL_IMAGE_SYMLINK_NAME}.bin >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGE_SYMLINK_NAME}.bin >> + ln -sf ${KERNEL_IMAGE_BASE_NAME}.bin ${KERNEL_IMAGETYPE} >> + cd - >> install -m 0644 System.map ${D}/boot/System.map-${KERNEL_VERSION} >> install -m 0644 .config ${D}/boot/config-${KERNEL_VERSION} >> install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION} > > This is going to break users who rely on the existing naming/layout. > > The patch description is lacking on why we need to do this too, it just says what you're doing and not why. > > Cheers, > > Richard > > > [Liu Ting-B28495] on our side, we used two ways to load the kernel images. 1) load from Ethernet 2) load from hard disk which deployed with the rootfs image containing kernel image (installing the package 'kernel-image'). We cannot use the same bootargs in u-boot due to the mismatched name. Ting, I understand what you said but what does this have to do with u-boot bootargs? Need a bit more info here. Can you tell us what images are generated before, and after your patch? And also, update the commit message with this info? -M > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-07-17 9:57 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-07-12 9:17 [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR b28495 2012-07-12 9:17 ` [PATCH] linux-dtb.inc: update dtb " b28495 2012-07-12 11:03 ` Richard Purdie 2012-07-15 11:07 ` Liu Ting-B28495 2012-07-16 22:23 ` McClintock Matthew-B29882 2012-07-12 11:02 ` [PATCH] kernel.bbclass: update image " Richard Purdie 2012-07-15 11:18 ` Liu Ting-B28495 2012-07-15 16:02 ` Khem Raj 2012-07-17 8:30 ` Liu Ting-B28495 2012-07-16 22:20 ` McClintock Matthew-B29882
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox