* [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar.
@ 2012-07-19 10:00 Martin Ertsaas
2012-07-19 10:18 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Martin Ertsaas @ 2012-07-19 10:00 UTC (permalink / raw)
To: openembedded-core; +Cc: Martin Ertsaas
Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
---
meta/classes/toolchain-scripts.bbclass | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
index bf37ec9..8f7c644 100644
--- a/meta/classes/toolchain-scripts.bbclass
+++ b/meta/classes/toolchain-scripts.bbclass
@@ -68,8 +68,8 @@ toolchain_create_tree_env_script () {
echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
- echo 'export AR=${TARGET_PREFIX}-ar' >> $script
- echo 'export NM=${TARGET_PREFIX}-nm' >> $script
+ echo 'export AR=${TARGET_PREFIX}ar' >> $script
+ echo 'export NM=${TARGET_PREFIX}nm' >> $script
echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${BUILD_SYS} --with-libtool-sysroot=${STAGING_DIR_TARGET}"' >> $script
if [ "${TARGET_OS}" = "darwin8" ]; then
--
1.7.8.6
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar.
2012-07-19 10:00 [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar Martin Ertsaas
@ 2012-07-19 10:18 ` Richard Purdie
2012-07-19 10:28 ` Robert P. J. Day
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2012-07-19 10:18 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Ertsaas
On Thu, 2012-07-19 at 12:00 +0200, Martin Ertsaas wrote:
> Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
> ---
> meta/classes/toolchain-scripts.bbclass | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> index bf37ec9..8f7c644 100644
> --- a/meta/classes/toolchain-scripts.bbclass
> +++ b/meta/classes/toolchain-scripts.bbclass
> @@ -68,8 +68,8 @@ toolchain_create_tree_env_script () {
> echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> - echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> - echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> + echo 'export AR=${TARGET_PREFIX}ar' >> $script
> + echo 'export NM=${TARGET_PREFIX}nm' >> $script
> echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${BUILD_SYS} --with-libtool-sysroot=${STAGING_DIR_TARGET}"' >> $script
> if [ "${TARGET_OS}" = "darwin8" ]; then
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar.
2012-07-19 10:18 ` Richard Purdie
@ 2012-07-19 10:28 ` Robert P. J. Day
2012-07-19 10:44 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2012-07-19 10:28 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Ertsaas
On Thu, 19 Jul 2012, Richard Purdie wrote:
> On Thu, 2012-07-19 at 12:00 +0200, Martin Ertsaas wrote:
> > Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
> > ---
> > meta/classes/toolchain-scripts.bbclass | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> > index bf37ec9..8f7c644 100644
> > --- a/meta/classes/toolchain-scripts.bbclass
> > +++ b/meta/classes/toolchain-scripts.bbclass
> > @@ -68,8 +68,8 @@ toolchain_create_tree_env_script () {
> > echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> > echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> > echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> > - echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> > - echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> > + echo 'export AR=${TARGET_PREFIX}ar' >> $script
> > + echo 'export NM=${TARGET_PREFIX}nm' >> $script
> > echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> > echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${BUILD_SYS} --with-libtool-sysroot=${STAGING_DIR_TARGET}"' >> $script
> > if [ "${TARGET_OS}" = "darwin8" ]; then
>
> Merged to master, thanks.
there appear to be more of those, based on a simple grep:
$ grep -rn "TARGET_PREFIX}-" *
meta/classes/toolchain-scripts.bbclass:27: echo 'export AR=${TARGET_PREFIX}-ar' >> $script
meta/classes/toolchain-scripts.bbclass:28: echo 'export NM=${TARGET_PREFIX}-nm' >> $script
meta/classes/toolchain-scripts.bbclass:114: echo 'export AR=${TARGET_PREFIX}-ar' >> $script
meta/classes/toolchain-scripts.bbclass:115: echo 'export NM=${TARGET_PREFIX}-nm' >> $script
$
just an observation.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar.
2012-07-19 10:28 ` Robert P. J. Day
@ 2012-07-19 10:44 ` Richard Purdie
0 siblings, 0 replies; 4+ messages in thread
From: Richard Purdie @ 2012-07-19 10:44 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Martin Ertsaas
On Thu, 2012-07-19 at 06:28 -0400, Robert P. J. Day wrote:
> On Thu, 19 Jul 2012, Richard Purdie wrote:
>
> > On Thu, 2012-07-19 at 12:00 +0200, Martin Ertsaas wrote:
> > > Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
> > > ---
> > > meta/classes/toolchain-scripts.bbclass | 4 ++--
> > > 1 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> > > index bf37ec9..8f7c644 100644
> > > --- a/meta/classes/toolchain-scripts.bbclass
> > > +++ b/meta/classes/toolchain-scripts.bbclass
> > > @@ -68,8 +68,8 @@ toolchain_create_tree_env_script () {
> > > echo 'export RANLIB=${TARGET_PREFIX}ranlib' >> $script
> > > echo 'export OBJCOPY=${TARGET_PREFIX}objcopy' >> $script
> > > echo 'export OBJDUMP=${TARGET_PREFIX}objdump' >> $script
> > > - echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> > > - echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> > > + echo 'export AR=${TARGET_PREFIX}ar' >> $script
> > > + echo 'export NM=${TARGET_PREFIX}nm' >> $script
> > > echo 'export TARGET_PREFIX=${TARGET_PREFIX}' >> $script
> > > echo 'export CONFIGURE_FLAGS="--target=${TARGET_SYS} --host=${TARGET_SYS} --build=${BUILD_SYS} --with-libtool-sysroot=${STAGING_DIR_TARGET}"' >> $script
> > > if [ "${TARGET_OS}" = "darwin8" ]; then
> >
> > Merged to master, thanks.
>
> there appear to be more of those, based on a simple grep:
>
> $ grep -rn "TARGET_PREFIX}-" *
> meta/classes/toolchain-scripts.bbclass:27: echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> meta/classes/toolchain-scripts.bbclass:28: echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> meta/classes/toolchain-scripts.bbclass:114: echo 'export AR=${TARGET_PREFIX}-ar' >> $script
> meta/classes/toolchain-scripts.bbclass:115: echo 'export NM=${TARGET_PREFIX}-nm' >> $script
> $
>
> just an observation.
Thanks, I've pushed something fixing those up too.
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-07-19 10:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-19 10:00 [PATCH] Remove the - between ${TARGET_PREFIX} and ar/nm for the env script, as this will make autotools look for arm-none-linux-gnueabi--ar instead of arm-none-linux-gnueabi-ar Martin Ertsaas
2012-07-19 10:18 ` Richard Purdie
2012-07-19 10:28 ` Robert P. J. Day
2012-07-19 10:44 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox