Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: is "export IMAGE_BASENAME" currently supported or not?
Date: Thu, 26 Jul 2012 23:33:55 +0100	[thread overview]
Message-ID: <1343342035.9574.107.camel@ted> (raw)
In-Reply-To: <alpine.DEB.2.02.1207261800480.15478@oneiric>

On Thu, 2012-07-26 at 18:02 -0400, Robert P. J. Day wrote:
> from image.bbclass:
> 
> # "export IMAGE_BASENAME" not supported at this time
> IMAGE_INSTALL ?= ""
> IMAGE_INSTALL[type] = "list"
> IMAGE_BASENAME[export] = "1"

I suspect back in time this looked like:

# "export IMAGE_BASENAME" not supported at this time
IMAGE_BASENAME[export] = "1"

and what the person wanted to do was:

export IMAGE_BASENAME

i.e. export and already set variable. At that time, the syntax was not
supported, I believe that it now is and has been for a while.

So a nice cleanup would be to change it to the above and remove the
comment.

> but there's this:
> 
> meta/recipes-core/images/core-image-minimal-initramfs.bb:export IMAGE_BASENAME = "core-image-minimal-initramfs"

so we can drop the "export" from there since the core does it.

Whether the export is needed at all these days, I don't know.

Cheers,

Richard




      reply	other threads:[~2012-07-26 22:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26 22:02 is "export IMAGE_BASENAME" currently supported or not? Robert P. J. Day
2012-07-26 22:33 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343342035.9574.107.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox