is "export IMAGE_BASENAME" currently supported or not?

is "export IMAGE_BASENAME" currently supported or not?

[Robert P. J. Day]

from image.bbclass:

# "export IMAGE_BASENAME" not supported at this time
IMAGE_INSTALL ?= ""
IMAGE_INSTALL[type] = "list"
IMAGE_BASENAME[export] = "1"

but there's this:

meta/recipes-core/images/core-image-minimal-initramfs.bb:export IMAGE_BASENAME = "core-image-minimal-initramfs"


just an observation.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: is "export IMAGE_BASENAME" currently supported or not?

[Richard Purdie]

On Thu, 2012-07-26 at 18:02 -0400, Robert P. J. Day wrote:
> from image.bbclass:
> 
> # "export IMAGE_BASENAME" not supported at this time
> IMAGE_INSTALL ?= ""
> IMAGE_INSTALL[type] = "list"
> IMAGE_BASENAME[export] = "1"

I suspect back in time this looked like:

# "export IMAGE_BASENAME" not supported at this time
IMAGE_BASENAME[export] = "1"

and what the person wanted to do was:

export IMAGE_BASENAME

i.e. export and already set variable. At that time, the syntax was not
supported, I believe that it now is and has been for a while.

So a nice cleanup would be to change it to the above and remove the
comment.

> but there's this:
> 
> meta/recipes-core/images/core-image-minimal-initramfs.bb:export IMAGE_BASENAME = "core-image-minimal-initramfs"

so we can drop the "export" from there since the core does it.

Whether the export is needed at all these days, I don't know.

Cheers,

Richard