From: Phil Blundell <philb@gnu.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] insane.bbclass: Fix RPATH warning in the face of funny path strings
Date: Thu, 16 Aug 2012 09:39:45 +0100 [thread overview]
Message-ID: <1345106385.7750.76.camel@x121e.pbcl.net> (raw)
In-Reply-To: <1345070782-4518-2-git-send-email-andy.ross@windriver.com>
On Wed, 2012-08-15 at 15:46 -0700, Andy Ross wrote:
> In toolchain edge cases it's possible for the RPATH of a library to be
> set to something like "/usr/lib/../lib". This should be detected as
> "/usr/lib" and generate a warning. Also clarify the warning text to
> indicate potential link-time pollution from the host libraries.
If these RPATHs are causing host pollution then that sounds like there
is another bug elsewhere. They ought to be resolved relative to the
sysroot during link edit.
It's also tempting to say that we should, unconditionally, normalise any
RPATHs which contain .. or . components before insane.bbclass runs.
Having extra, redundant, components in the pathname will just cause
extra work for ld.so (and hence run-time slowness) and bring no benefit.
Doing that would mean that the existing check would catch things like
the case you mentioned automatically.
p.
next prev parent reply other threads:[~2012-08-16 8:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 22:46 [PATCH] Fix RPATH warning vs. weird paths Andy Ross
2012-08-15 22:46 ` [PATCH] insane.bbclass: Fix RPATH warning in the face of funny path strings Andy Ross
2012-08-16 0:14 ` Chris Larson
2012-08-16 16:10 ` Andy Ross
2012-08-16 16:10 ` Andy Ross
2012-08-16 8:39 ` Phil Blundell [this message]
2012-08-16 17:43 ` Andy Ross
2012-08-17 10:28 ` Richard Purdie
2012-08-17 15:02 ` Andy Ross
-- strict thread matches above, loose matches on Subject: below --
2012-08-17 16:20 [PATCH 1/2] " Richard Purdie
2012-08-20 21:05 ` [PATCH] " Andy Ross
2012-08-21 15:49 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345106385.7750.76.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox