Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] adt-installer: add support for relocatable SDK
Date: Fri, 17 Aug 2012 11:56:46 +0100	[thread overview]
Message-ID: <1345201006.26132.21.camel@ted> (raw)
In-Reply-To: <CALbNGRR3A35Jx2ia2S4s_RVQ5O2v1g1EUQALyLBtwj4=KDnXxA@mail.gmail.com>

On Fri, 2012-08-17 at 12:42 +0200, Andreas Müller wrote:
> On Fri, Aug 17, 2012 at 11:38 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Fri, 2012-08-17 at 06:44 +0300, Laurentiu Palcu wrote:
> >> Since we made the SDK relocatable, we have to add this functionality to
> >> adt-installer too.
> >>
> >> Other:
> >>  - Changed tabs to spaces in the recipe file too.
> >
> > Shell functions use tabs, python uses spaces. The OE TSC has thought
> > long and hard about this and that is the decision. Its not perfect but
> > the alternatives will cause more problems than any benefit is worth.
> Is there some report/log/styleguide helping me to understand why we
> use two tab/space strategies instead of having spaces for all?

This is the style the bulk of the metadata uses. We really don't want
patches changing a significant portion of the metadata for cosmetic
reasons. It would create a world of pain for people handling/merging
patches, a lot of needless code churn and significant problems for
people trying to backport changes to older versions of the code base
amongst other reasons.

Cheers,

Richard




      reply	other threads:[~2012-08-17 11:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17  3:44 [PATCH 0/3] Add support for relocatable SDK to ADT installer and some fixes Laurentiu Palcu
2012-08-17  3:44 ` [PATCH 1/3] populate_sdk_base.bbclass: fix SDK relocation issues Laurentiu Palcu
2012-08-17  3:44 ` [PATCH 2/3] package.bbclass: change RPATHs for cross-canadian binaries Laurentiu Palcu
2012-08-17  3:44 ` [PATCH 3/3] adt-installer: add support for relocatable SDK Laurentiu Palcu
2012-08-17  9:38   ` Richard Purdie
2012-08-17 10:16     ` Laurentiu Palcu
2012-08-17 10:42     ` Andreas Müller
2012-08-17 10:56       ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345201006.26132.21.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox