Re: [PATCH 1/1] ia32-base.inc: new include file

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2012-08-25 at 09:45 +0200, Koen Kooi wrote:
> Op 25 aug. 2012, om 06:34 heeft tom.zanussi@intel.com het volgende geschreven:
> 
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > This is the ia32-base.inc moved over from meta-intel.  See meta-intel
> > for the complete history of contributions to this file.
> > 
> > Here's the initial commit text that explains the purpose of this file:
> > 
> >  The meta-intel BSPs currently have a number of machine settings common
> >  to all - factor these out into a common include file.
> > 
> >  Also add several new intel-specific XSERVER variables for building
> >  XSERVER variables in BSPs.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> > ---
> > meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++
> > 
> > +# glibc-related variables
> > +#
> > +GLIBC_ADDONS ?= "nptl"
> 
> That's a distro setting

Yes and no. It makes sense for architectures to have sane defaults and I
class nptl on ia32 as that. We want OE-Core to function distroless but
allow distros to change things where it makes sense to them. So I'd
argue this is reasonable.

I seem to remember a number of issues where ia32 defaulted to something
less sane going back in time and you needed this on every ia32 machine.
As has been pointed out, this is probably redundant now. If that is the
case, great, lets clean it up. As I mention to Khem, having one place to
cleanup is better than a whole load of different places.

So I see more in favour of merging this and working on improvements than
not merging it as things stand.

Cheers,

Richard