Re: [PATCH 1/1] ia32-base.inc: new include file

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Sat, 2012-08-25 at 16:17 +0200, Koen Kooi wrote:
> Op 25 aug. 2012, om 13:56 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:
> 
> > On Sat, 2012-08-25 at 09:45 +0200, Koen Kooi wrote:
> >> Op 25 aug. 2012, om 06:34 heeft tom.zanussi@intel.com het volgende geschreven:
> >> 
> >>> From: Tom Zanussi <tom.zanussi@intel.com>
> >>> 
> >>> This is the ia32-base.inc moved over from meta-intel.  See meta-intel
> >>> for the complete history of contributions to this file.
> >>> 
> >>> Here's the initial commit text that explains the purpose of this file:
> >>> 
> >>> The meta-intel BSPs currently have a number of machine settings common
> >>> to all - factor these out into a common include file.
> >>> 
> >>> Also add several new intel-specific XSERVER variables for building
> >>> XSERVER variables in BSPs.
> >>> 
> >>> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> >>> ---
> >>> meta/conf/machine/include/ia32-base.inc | 58 +++++++++++++++++++++++++++++++++
> >>> 
> >>> +# glibc-related variables
> >>> +#
> >>> +GLIBC_ADDONS ?= "nptl"
> >> 
> >> That's a distro setting
> > 
> > Yes and no. It makes sense for architectures to have sane defaults and I
> > class nptl on ia32 as that. We want OE-Core to function distroless but
> > allow distros to change things where it makes sense to them. So I'd
> > argue this is reasonable.
> 
> So put it in default-distrovars, not in a machine 'tune' file.

This was only seemingly needed on x86 for reasons which I no longer
understand and are likely historical and irrelevant now. So yes, we
could add it there with an arch override. The likely outcome is the
thing will just get removed so I'm finding it hard to get worked up
about it though.

Cheers,

Richard