[PATCH 0/1] add flex/bison to perf DEPENDS

[PATCH 0/1] add flex/bison to perf DEPENDS

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

To potentially fix a build problem seen on the yocto autobuilder.

I'm not able to reproduce the problem myself without this patch,
but it looks like these dependencies should be added regardless.

The following changes since commit b4c5725af4cd85d5644f0373e2674e903c4eab2b:

  yocto-bsp: add missing xserver-xf86-config .bbappend for qemu (2012-08-25 14:47:07 +0100)

are available in the git repository at:
  git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-bison-flex-depends
  http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-bison-flex-depends

Tom Zanussi (1):
  perf: add bison and flex to DEPENDS

 meta/recipes-kernel/perf/perf_3.4.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

-- 
1.7.4.1

[PATCH 1/1] perf: add bison and flex to DEPENDS

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

perf depends on bison and flex for event parsing - add them as
dependencies.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/recipes-kernel/perf/perf_3.4.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
index 5fb38e6..decc911 100644
--- a/meta/recipes-kernel/perf/perf_3.4.bb
+++ b/meta/recipes-kernel/perf/perf_3.4.bb
@@ -9,7 +9,7 @@ as well."
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
 
-PR = "r4"
+PR = "r5"
 
 require perf.inc
 
@@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \
            ${MLPREFIX}binutils \
            ${TUI_DEPENDS} \
            ${SCRIPTING_DEPENDS} \
+           bison flex \
           "
 
 SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl perl-modules python', '',d)}"
-- 
1.7.4.1

Re: [PATCH 1/1] perf: add bison and flex to DEPENDS

[Richard Purdie]

On Sat, 2012-08-25 at 17:57 -0500, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> perf depends on bison and flex for event parsing - add them as
> dependencies.

Does it need these at build time or runtime? I suspect you meant to add
these as RDEPENDS as it needs them at runtime?

Cheers,

Richard

> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> ---
>  meta/recipes-kernel/perf/perf_3.4.bb |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
> index 5fb38e6..decc911 100644
> --- a/meta/recipes-kernel/perf/perf_3.4.bb
> +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> @@ -9,7 +9,7 @@ as well."
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
>  
> -PR = "r4"
> +PR = "r5"
>  
>  require perf.inc
>  
> @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \
>             ${MLPREFIX}binutils \
>             ${TUI_DEPENDS} \
>             ${SCRIPTING_DEPENDS} \
> +           bison flex \
>            "
>  
>  SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl perl-modules python', '',d)}"

Re: [PATCH 1/1] perf: add bison and flex to DEPENDS

[Tom Zanussi]

On Sun, 2012-08-26 at 09:35 +0100, Richard Purdie wrote:
> On Sat, 2012-08-25 at 17:57 -0500, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > perf depends on bison and flex for event parsing - add them as
> > dependencies.
> 
> Does it need these at build time or runtime? I suspect you meant to add
> these as RDEPENDS as it needs them at runtime?
> 

Build-time e.g. pmu.y --> pmu-bison.c --> pmu.o

So it should be DEPENDS...

Tom

> Cheers,
> 
> Richard
> 
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> > ---
> >  meta/recipes-kernel/perf/perf_3.4.bb |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/meta/recipes-kernel/perf/perf_3.4.bb b/meta/recipes-kernel/perf/perf_3.4.bb
> > index 5fb38e6..decc911 100644
> > --- a/meta/recipes-kernel/perf/perf_3.4.bb
> > +++ b/meta/recipes-kernel/perf/perf_3.4.bb
> > @@ -9,7 +9,7 @@ as well."
> >  LICENSE = "GPLv2"
> >  LIC_FILES_CHKSUM = "file://COPYING;md5=d7810fab7487fb0aad327b76f1be7cd7"
> >  
> > -PR = "r4"
> > +PR = "r5"
> >  
> >  require perf.inc
> >  
> > @@ -24,6 +24,7 @@ DEPENDS = "virtual/kernel \
> >             ${MLPREFIX}binutils \
> >             ${TUI_DEPENDS} \
> >             ${SCRIPTING_DEPENDS} \
> > +           bison flex \
> >            "
> >  
> >  SCRIPTING_RDEPENDS = "${@perf_feature_enabled('perf-scripting', 'perl perl-modules python', '',d)}"
> 
> 

Re: [PATCH 0/1] add flex/bison to perf DEPENDS

[Saul Wold]

On 08/25/2012 03:57 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
>
> To potentially fix a build problem seen on the yocto autobuilder.
>
> I'm not able to reproduce the problem myself without this patch,
> but it looks like these dependencies should be added regardless.
>
> The following changes since commit b4c5725af4cd85d5644f0373e2674e903c4eab2b:
>
>    yocto-bsp: add missing xserver-xf86-config .bbappend for qemu (2012-08-25 14:47:07 +0100)
>
> are available in the git repository at:
>    git://git.yoctoproject.org/poky-contrib.git tzanussi/perf-bison-flex-depends
>    http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=tzanussi/perf-bison-flex-depends
>
> Tom Zanussi (1):
>    perf: add bison and flex to DEPENDS
>
>   meta/recipes-kernel/perf/perf_3.4.bb |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
Merged into OE-Core

Thanks
	Sau!