From: Phil Blundell <philb@gnu.org>
To: Saul Wold <sgw@linux.intel.com>
Cc: Marc Ferland <marc.ferland@gmail.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] openssh: allow root login when debug-tweaks is enabled
Date: Fri, 07 Sep 2012 22:09:17 +0100 [thread overview]
Message-ID: <1347052157.4396.225.camel@x121e.pbcl.net> (raw)
In-Reply-To: <1347041849-1559-1-git-send-email-sgw@linux.intel.com>
On Fri, 2012-09-07 at 11:17 -0700, Saul Wold wrote:
> + for i in ${IMAGE_FEATURES};
> + do
> + if [ ${i} = "debug-tweaks" ]; then
Using ${IMAGE_FEATURES} in a package postinst is pretty unwholesome. If
you do:
$ IMAGE_FEATURES=debug-tweaks bitbake openssh
$ sleep $[21*86400]
$ IMAGE_FEATURES=no-debug-tweaks bitbake my-production-image
then there is a significant risk that you will accidentally get the
insecure openssh in your image without realising it.
I know dropbear does this sort of thing already but we should really try
not to add more of that stuff. If it's an IMAGE_FEATURE then it should
really be getting handled at the rootfs level, not burned into the
packages in the feed.
p.
next prev parent reply other threads:[~2012-09-07 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 18:17 [PATCH] openssh: allow root login when debug-tweaks is enabled Saul Wold
2012-09-07 20:52 ` Khem Raj
2012-09-07 21:04 ` Saul Wold
2012-09-07 21:09 ` Phil Blundell [this message]
2012-09-07 22:49 ` Khem Raj
2012-09-07 23:56 ` Paul Eggleton
2012-09-08 0:03 ` Saul Wold
2012-09-08 0:13 ` Paul Eggleton
-- strict thread matches above, loose matches on Subject: below --
2012-09-07 22:20 Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347052157.4396.225.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=marc.ferland@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox