Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Marc Ferland <marc.ferland@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] openssh: allow root login when debug-tweaks is enabled
Date: Fri, 07 Sep 2012 14:04:35 -0700	[thread overview]
Message-ID: <504A6163.8020704@linux.intel.com> (raw)
In-Reply-To: <CAMKF1sq3OboaitVyZYqNSaedp2UFZ0m6QJ8Bznw0uFgQR8kG-A@mail.gmail.com>

On 09/07/2012 01:52 PM, Khem Raj wrote:
> On Fri, Sep 7, 2012 at 11:17 AM, Saul Wold <sgw@linux.intel.com> wrote:
>> +       for i in ${IMAGE_FEATURES};
>> +       do
>> +               if [ ${i} = "debug-tweaks" ]; then
>> +                       sed -i -e "s/^#PermitRootLogin/PermitRootLogin/" ${D}${sysconfdir}/ssh/sshd_config
>> +                       sed -i -e "s/^#PermitEmptyPasswords no/PermitEmptyPasswords yes/" ${D}${sysconfdir}/ssh/sshd_config
>> +               fi
>> +       done
>
> instead of looping could you apply same logic as in dropbear to do this thing ?
>
>
dropbear seems to do it as a patch, not in the do_install_append, also 
looking at dropbear it may be possible to simplify that it seems like 
it's a 2 step process that could be done in one step.  I think 
DISTRO_TYPE is only used in dropbear.

I guess its possible to export a variable that can be read by the 
install_append(), I will give it a test.

Sau!




  reply	other threads:[~2012-09-07 21:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 18:17 [PATCH] openssh: allow root login when debug-tweaks is enabled Saul Wold
2012-09-07 20:52 ` Khem Raj
2012-09-07 21:04   ` Saul Wold [this message]
2012-09-07 21:09 ` Phil Blundell
2012-09-07 22:49   ` Khem Raj
2012-09-07 23:56 ` Paul Eggleton
2012-09-08  0:03   ` Saul Wold
2012-09-08  0:13     ` Paul Eggleton
  -- strict thread matches above, loose matches on Subject: below --
2012-09-07 22:20 Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504A6163.8020704@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=marc.ferland@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox