Re: [PATCH] eglibc: Fix for dynamic linker broken offset

[Phil Blundell <philb@gnu.org>]

On Fri, 2012-09-28 at 08:57 -0500, Mark Hatle wrote:
> On 9/28/12 4:52 AM, Phil Blundell wrote:
> > On Mon, 2012-09-24 at 15:40 +0300, Andrei Dinu wrote:
> >> On 09/24/2012 02:30 PM, Phil Blundell wrote:
> >>> On Mon, 2012-09-24 at 14:26 +0300, Andrei Dinu wrote:
> >>>> +-	    *reloc_addr += sym->st_value;
> >>>> ++	    *reloc_addr = sym->st_value;
> >>> That patch looks slightly dubious to me.  Are you sure this doesn't
> >>> introduce any regressions elsewhere?
> >>>
> >> I have insufficient data to affirm that it doesn't introduces regressions.
> >
> > Presumably it does at least pass the eglibc and binutils testsuites,
> > right?
> 
> That patch is a workaround for an ARM issue related to thread local storage and 
> TLS offsets during runtime and prelinking.
> 
> See https://bugzilla.yoctoproject.org/show_bug.cgi?id=1443
> 
> Note, this is simply a workaround and not a final solution as it hasn't been 
> vetted upstream.

Right, I understand that.  But this doesn't really answer the question
"does the workaround break anything else?".

p.