From: Phil Blundell <philb@gnu.org>
To: Andrei Dinu <andrei.adrianx.dinu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] eglibc: Fix for dynamic linker broken offset
Date: Fri, 28 Sep 2012 10:52:30 +0100 [thread overview]
Message-ID: <1348825951.32611.30.camel@phil-desktop> (raw)
In-Reply-To: <506054A0.6090309@intel.com>
On Mon, 2012-09-24 at 15:40 +0300, Andrei Dinu wrote:
> On 09/24/2012 02:30 PM, Phil Blundell wrote:
> > On Mon, 2012-09-24 at 14:26 +0300, Andrei Dinu wrote:
> >> +- *reloc_addr += sym->st_value;
> >> ++ *reloc_addr = sym->st_value;
> > That patch looks slightly dubious to me. Are you sure this doesn't
> > introduce any regressions elsewhere?
> >
> >
> I have insufficient data to affirm that it doesn't introduces regressions.
Presumably it does at least pass the eglibc and binutils testsuites,
right?
p.
next prev parent reply other threads:[~2012-09-28 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 11:26 [PATCH] eglibc: Fix for dynamic linker broken offset Andrei Dinu
2012-09-24 11:30 ` Phil Blundell
2012-09-24 12:40 ` Andrei Dinu
2012-09-28 9:52 ` Phil Blundell [this message]
2012-09-28 13:57 ` Mark Hatle
2012-09-28 14:00 ` Khem Raj
2012-09-28 14:02 ` Phil Blundell
2012-09-28 14:35 ` Mark Hatle
2012-09-28 14:50 ` Khem Raj
2012-09-28 14:57 ` Phil Blundell
2012-09-28 15:02 ` Mark Hatle
[not found] ` <50659938.4060401@intel.com>
2012-10-02 16:50 ` Phil Blundell
2012-09-24 14:34 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348825951.32611.30.camel@phil-desktop \
--to=philb@gnu.org \
--cc=andrei.adrianx.dinu@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox