Re: [PATCH] sstate: Add detail to shared area warning

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Tue, 2012-10-02 at 23:00 +0100, Phil Blundell wrote:
> On Tue, 2012-10-02 at 15:00 -0700, Saul Wold wrote:
> > -        bb.warn("The recipe is trying to install files into a shared area when those files already exist. Those files are:\n   %s" % "\n   ".join(match))
> > +        bb.warn("The %s recipe is trying to install files into a shared area when those files already exist (please fix %s). Those files are:\n   %s" % (d.getVar('PN', True), d.getVar('FILE', True), "\n   ".join(match)))
> 
> That seems potentially misleading: the file that needs fixing isn't
> necessarily the one that triggers this warning.  What would be ideal
> would be to have it output the names of all recipes that have tried to
> stage the files in question so that the user can make an informed
> decision about which one ought to be putting them there.

*if* you can get that information. The python recipe is poking things
into the sysroot outside the knowledge of sstate, then triggering a
warning. We have no way to know who put files there if it wasn't done
through sstate.

This isn't to say we shouldn't improve the message and use the sstate
manifests to find any culprits, just that we can't find an answer in all
cases.

Cheers,

Richard