Re: [PATCH] sstate: Add detail to shared area warning

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2012-10-03 at 00:11 +0200, Martin Jansa wrote:
> On Tue, Oct 02, 2012 at 11:00:53PM +0100, Phil Blundell wrote:
> > On Tue, 2012-10-02 at 15:00 -0700, Saul Wold wrote:
> > > -        bb.warn("The recipe is trying to install files into a shared area when those files already exist. Those files are:\n   %s" % "\n   ".join(match))
> > > +        bb.warn("The %s recipe is trying to install files into a shared area when those files already exist (please fix %s). Those files are:\n   %s" % (d.getVar('PN', True), d.getVar('FILE', True), "\n   ".join(match)))
> > 
> > That seems potentially misleading: the file that needs fixing isn't
> > necessarily the one that triggers this warning.  What would be ideal
> > would be to have it output the names of all recipes that have tried to
> > stage the files in question so that the user can make an informed
> > decision about which one ought to be putting them there.
> 
> Maybe something like master.list was before
> http://git.openembedded.org/openembedded-core/commit/?id=603daf343ad3f18c8adb799e3625ae2a18d94f56
> with added recipe name, but that doesn't detect files already 

We can list any sstate manifest files (tmp/sstate-control) also adding
that file which may or may not have a listing of it. We might as well
just grep those files and print matches.

We are not going back to a master.list file, its a performance headache.

Cheers,

Richard