* [PATCH 0/1] fix path in perl @INC @ 2012-10-09 8:32 Kang Kai 2012-10-09 8:32 ` [PATCH 1/1] perl: fix @INC Kang Kai 0 siblings, 1 reply; 6+ messages in thread From: Kang Kai @ 2012-10-09 8:32 UTC (permalink / raw) To: openembedded-core The following changes since commit eb8ac50d58575be3e04c4decc5b0e2d80381be9b: documentation: dev-manual - mentioned SRC_URI in the kernel example (2012-10-07 13:15:37 +0100) are available in the git repository at: git://git.pokylinux.org/poky-contrib kangkai/distro http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/distro Kang Kai (1): perl: fix @INC meta/recipes-devtools/perl/perl-5.14.2/config.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- 1.7.5.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] perl: fix @INC 2012-10-09 8:32 [PATCH 0/1] fix path in perl @INC Kang Kai @ 2012-10-09 8:32 ` Kang Kai 2012-10-09 13:10 ` Richard Purdie 0 siblings, 1 reply; 6+ messages in thread From: Kang Kai @ 2012-10-09 8:32 UTC (permalink / raw) To: openembedded-core perl @INC path includes native perl modules path. When run "perl -V", the output at the end is something like: @INC: /etc/perl /usr/lib/perl/site_perl/5.14.2/ /usr/lib/perl/site_perl/5.14.2 /usr/lib/perl/vendor_perl/5.14.2/ /usr/lib/perl/vendor_perl/5.14.2 /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/ /usr/lib/perl/5.14.2 /usr/local/lib/site_perl /usr/lib/perl/5.14.2 . And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. Because the native path is compiled into libperl.so that sed in perl_package_preprocess() could NOT remove it. So revert the commit. [Yocto #3099] Signed-off-by: Kang Kai <kai.kang@windriver.com> --- meta/recipes-devtools/perl/perl-5.14.2/config.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/recipes-devtools/perl/perl-5.14.2/config.sh b/meta/recipes-devtools/perl/perl-5.14.2/config.sh index 0d4ca1c..dbfabb5 100644 --- a/meta/recipes-devtools/perl/perl-5.14.2/config.sh +++ b/meta/recipes-devtools/perl/perl-5.14.2/config.sh @@ -68,7 +68,7 @@ api_version='14' api_versionstring='5.14.0' ar='ar' archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' -archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' +archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' archname64='' archname='@ARCH@-thread-multi' archobjs='' -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] perl: fix @INC 2012-10-09 8:32 ` [PATCH 1/1] perl: fix @INC Kang Kai @ 2012-10-09 13:10 ` Richard Purdie 2012-10-09 14:12 ` Tom Zanussi 0 siblings, 1 reply; 6+ messages in thread From: Richard Purdie @ 2012-10-09 13:10 UTC (permalink / raw) To: Kang Kai; +Cc: openembedded-core On Tue, 2012-10-09 at 16:32 +0800, Kang Kai wrote: > perl @INC path includes native perl modules path. When run "perl -V", > the output at the end is something like: > @INC: > /etc/perl > /usr/lib/perl/site_perl/5.14.2/ > /usr/lib/perl/site_perl/5.14.2 > /usr/lib/perl/vendor_perl/5.14.2/ > /usr/lib/perl/vendor_perl/5.14.2 > /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/ > /usr/lib/perl/5.14.2 > /usr/local/lib/site_perl > /usr/lib/perl/5.14.2 > . > > And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. > Because the native path is compiled into libperl.so that sed in > perl_package_preprocess() could NOT remove it. So revert the commit. > > [Yocto #3099] > > Signed-off-by: Kang Kai <kai.kang@windriver.com> > --- > meta/recipes-devtools/perl/perl-5.14.2/config.sh | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-devtools/perl/perl-5.14.2/config.sh b/meta/recipes-devtools/perl/perl-5.14.2/config.sh > index 0d4ca1c..dbfabb5 100644 > --- a/meta/recipes-devtools/perl/perl-5.14.2/config.sh > +++ b/meta/recipes-devtools/perl/perl-5.14.2/config.sh > @@ -68,7 +68,7 @@ api_version='14' > api_versionstring='5.14.0' > ar='ar' > archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > -archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > +archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > archname64='' > archname='@ARCH@-thread-multi' > archobjs='' I dislike fixing one bug at the expense of breaking another. Tom, http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4 Any comments on this? How could we test the issue you originally fixed? Cheers, Richard ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] perl: fix @INC 2012-10-09 13:10 ` Richard Purdie @ 2012-10-09 14:12 ` Tom Zanussi 2012-10-10 0:52 ` Tom Zanussi 0 siblings, 1 reply; 6+ messages in thread From: Tom Zanussi @ 2012-10-09 14:12 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On Tue, 2012-10-09 at 14:10 +0100, Richard Purdie wrote: > On Tue, 2012-10-09 at 16:32 +0800, Kang Kai wrote: > > perl @INC path includes native perl modules path. When run "perl -V", > > the output at the end is something like: > > @INC: > > /etc/perl > > /usr/lib/perl/site_perl/5.14.2/ > > /usr/lib/perl/site_perl/5.14.2 > > /usr/lib/perl/vendor_perl/5.14.2/ > > /usr/lib/perl/vendor_perl/5.14.2 > > /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/ > > /usr/lib/perl/5.14.2 > > /usr/local/lib/site_perl > > /usr/lib/perl/5.14.2 > > . > > > > And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. > > Because the native path is compiled into libperl.so that sed in > > perl_package_preprocess() could NOT remove it. So revert the commit. > > > > [Yocto #3099] > > > > Signed-off-by: Kang Kai <kai.kang@windriver.com> > > --- > > meta/recipes-devtools/perl/perl-5.14.2/config.sh | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/meta/recipes-devtools/perl/perl-5.14.2/config.sh b/meta/recipes-devtools/perl/perl-5.14.2/config.sh > > index 0d4ca1c..dbfabb5 100644 > > --- a/meta/recipes-devtools/perl/perl-5.14.2/config.sh > > +++ b/meta/recipes-devtools/perl/perl-5.14.2/config.sh > > @@ -68,7 +68,7 @@ api_version='14' > > api_versionstring='5.14.0' > > ar='ar' > > archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > > -archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > > +archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > > archname64='' > > archname='@ARCH@-thread-multi' > > archobjs='' > > I dislike fixing one bug at the expense of breaking another. > > Tom, > > http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4 > > Any comments on this? How could we test the issue you originally fixed? > The original purpose of that commit was to allow the perf build to use ExtUtils::Embed to build the Perl language bindings for 'perf script'. perl_package_preprocess() was (I thought) supposed to prevent the settings in config.sh from making it to the target - I'll have to look into why they do for libperl.so. Tom > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] perl: fix @INC 2012-10-09 14:12 ` Tom Zanussi @ 2012-10-10 0:52 ` Tom Zanussi 2012-10-10 1:48 ` Kang Kai 0 siblings, 1 reply; 6+ messages in thread From: Tom Zanussi @ 2012-10-10 0:52 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On Tue, 2012-10-09 at 09:12 -0500, Tom Zanussi wrote: > On Tue, 2012-10-09 at 14:10 +0100, Richard Purdie wrote: > > On Tue, 2012-10-09 at 16:32 +0800, Kang Kai wrote: > > > perl @INC path includes native perl modules path. When run "perl -V", > > > the output at the end is something like: > > > @INC: > > > /etc/perl > > > /usr/lib/perl/site_perl/5.14.2/ > > > /usr/lib/perl/site_perl/5.14.2 > > > /usr/lib/perl/vendor_perl/5.14.2/ > > > /usr/lib/perl/vendor_perl/5.14.2 > > > /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/ > > > /usr/lib/perl/5.14.2 > > > /usr/local/lib/site_perl > > > /usr/lib/perl/5.14.2 > > > . > > > > > > And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. > > > Because the native path is compiled into libperl.so that sed in > > > perl_package_preprocess() could NOT remove it. So revert the commit. > > > > > > [Yocto #3099] > > > > > > Signed-off-by: Kang Kai <kai.kang@windriver.com> > > > --- > > > meta/recipes-devtools/perl/perl-5.14.2/config.sh | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/meta/recipes-devtools/perl/perl-5.14.2/config.sh b/meta/recipes-devtools/perl/perl-5.14.2/config.sh > > > index 0d4ca1c..dbfabb5 100644 > > > --- a/meta/recipes-devtools/perl/perl-5.14.2/config.sh > > > +++ b/meta/recipes-devtools/perl/perl-5.14.2/config.sh > > > @@ -68,7 +68,7 @@ api_version='14' > > > api_versionstring='5.14.0' > > > ar='ar' > > > archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > > > -archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > > > +archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' > > > archname64='' > > > archname='@ARCH@-thread-multi' > > > archobjs='' > > > > I dislike fixing one bug at the expense of breaking another. > > > > Tom, > > > > http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4 > > > > Any comments on this? How could we test the issue you originally fixed? > > > > The original purpose of that commit was to allow the perf build to use > ExtUtils::Embed to build the Perl language bindings for 'perf script'. > > perl_package_preprocess() was (I thought) supposed to prevent the > settings in config.sh from making it to the target - I'll have to look > into why they do for libperl.so. > I just submitted a patchset that gets rid of the @INC problem while still allowing perf scripting to work (rather than exiting with a 'scripting not supported' message). Tom > Tom > > > Cheers, > > > > Richard > > > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] perl: fix @INC 2012-10-10 0:52 ` Tom Zanussi @ 2012-10-10 1:48 ` Kang Kai 0 siblings, 0 replies; 6+ messages in thread From: Kang Kai @ 2012-10-10 1:48 UTC (permalink / raw) To: Tom Zanussi; +Cc: openembedded-core On 2012年10月10日 08:52, Tom Zanussi wrote: > On Tue, 2012-10-09 at 09:12 -0500, Tom Zanussi wrote: >> On Tue, 2012-10-09 at 14:10 +0100, Richard Purdie wrote: >>> On Tue, 2012-10-09 at 16:32 +0800, Kang Kai wrote: >>>> perl @INC path includes native perl modules path. When run "perl -V", >>>> the output at the end is something like: >>>> @INC: >>>> /etc/perl >>>> /usr/lib/perl/site_perl/5.14.2/ >>>> /usr/lib/perl/site_perl/5.14.2 >>>> /usr/lib/perl/vendor_perl/5.14.2/ >>>> /usr/lib/perl/vendor_perl/5.14.2 >>>> /mnt/sda10/poky-all-platform/build-qemuppc/tmp/sysroots/qemuppc/usr/lib/perl/5.14.2/ >>>> /usr/lib/perl/5.14.2 >>>> /usr/local/lib/site_perl >>>> /usr/lib/perl/5.14.2 >>>> . >>>> >>>> And this is caused by commit aeca6512f3a5468b8f65e2986024ab07d2ce45b4. >>>> Because the native path is compiled into libperl.so that sed in >>>> perl_package_preprocess() could NOT remove it. So revert the commit. >>>> >>>> [Yocto #3099] >>>> >>>> Signed-off-by: Kang Kai<kai.kang@windriver.com> >>>> --- >>>> meta/recipes-devtools/perl/perl-5.14.2/config.sh | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/meta/recipes-devtools/perl/perl-5.14.2/config.sh b/meta/recipes-devtools/perl/perl-5.14.2/config.sh >>>> index 0d4ca1c..dbfabb5 100644 >>>> --- a/meta/recipes-devtools/perl/perl-5.14.2/config.sh >>>> +++ b/meta/recipes-devtools/perl/perl-5.14.2/config.sh >>>> @@ -68,7 +68,7 @@ api_version='14' >>>> api_versionstring='5.14.0' >>>> ar='ar' >>>> archlib='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' >>>> -archlibexp='@STAGINGDIR@@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' >>>> +archlibexp='@LIBDIR@/perl/5.14.2/@ARCH@-thread-multi' >>>> archname64='' >>>> archname='@ARCH@-thread-multi' >>>> archobjs='' >>> I dislike fixing one bug at the expense of breaking another. >>> >>> Tom, >>> >>> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=aeca6512f3a5468b8f65e2986024ab07d2ce45b4 >>> >>> Any comments on this? How could we test the issue you originally fixed? >>> >> The original purpose of that commit was to allow the perf build to use >> ExtUtils::Embed to build the Perl language bindings for 'perf script'. >> >> perl_package_preprocess() was (I thought) supposed to prevent the >> settings in config.sh from making it to the target - I'll have to look >> into why they do for libperl.so. >> Hi Tom, Thanks. > I just submitted a patchset that gets rid of the @INC problem while > still allowing perf scripting to work (rather than exiting with a > 'scripting not supported' message). I'll test perl with your patch. Regards, Kai > > Tom > >> Tom >> >>> Cheers, >>> >>> Richard >>> >>> >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-10 2:01 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-10-09 8:32 [PATCH 0/1] fix path in perl @INC Kang Kai 2012-10-09 8:32 ` [PATCH 1/1] perl: fix @INC Kang Kai 2012-10-09 13:10 ` Richard Purdie 2012-10-09 14:12 ` Tom Zanussi 2012-10-10 0:52 ` Tom Zanussi 2012-10-10 1:48 ` Kang Kai
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox