From: Phil Blundell <philb@gnu.org>
To: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Cc: clarson@kergoth.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] package.bbclass: search for dangling links in installation directory
Date: Sun, 14 Oct 2012 15:58:51 +0100 [thread overview]
Message-ID: <1350226731.4470.90.camel@x121e.pbcl.net> (raw)
In-Reply-To: <lyvced8jpv.fsf@ensc-virt.intern.sigma-chemnitz.de>
On Sun, 2012-10-14 at 11:51 +0200, Enrico Scholz wrote:
> Chris Larson <clarson-ZYzTKstmaoRBDgjK7y7TUQ@public.gmane.org> writes:
>
> >> + # make path absolute; do not use os.path.join() here
> >> + # because target might start with multiple '/'
> >> + rtarget = inst_root + target
> >
> > I think you can use the join()
>
> no; I used it in an earlier version of the patch
>
> rtarget = os.path.join(inst_root, target[1:])
>
> and this fails for links like '//sbin/systemd'.
You somehow chopped off the important part of Chris's text. What he
actually wrote was "... the join() which is in the oe python package",
which is not the same as os.path.join.
As the comment says, it is...
"""Like os.path.join but doesn't treat absolute RHS specially"""
p.
next prev parent reply other threads:[~2012-10-14 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 12:12 [PATCH] package.bbclass: search for dangling links in installation directory Enrico Scholz
2012-10-14 1:46 ` Chris Larson
2012-10-14 9:51 ` Enrico Scholz
2012-10-14 14:58 ` Phil Blundell [this message]
2012-10-29 15:20 ` Enrico Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350226731.4470.90.camel@x121e.pbcl.net \
--to=philb@gnu.org \
--cc=clarson@kergoth.com \
--cc=enrico.scholz@sigma-chemnitz.de \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox