From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
To: openembedded-core@lists.openembedded.org
Cc: clarson@kergoth.com
Subject: Re: [PATCH] package.bbclass: search for dangling links in installation directory
Date: Sun, 14 Oct 2012 11:51:40 +0200 [thread overview]
Message-ID: <lyvced8jpv.fsf@ensc-virt.intern.sigma-chemnitz.de> (raw)
In-Reply-To: <CABcZANkPym+NSXqx6PrZnkhVqtsHoq-D20Dc14OgQ1Cq3G-bUQ@mail.gmail.com> (Chris Larson's message of "Sat, 13 Oct 2012 18:46:56 -0700")
Chris Larson <clarson-ZYzTKstmaoRBDgjK7y7TUQ@public.gmane.org> writes:
>> + # make path absolute; do not use os.path.join() here
>> + # because target might start with multiple '/'
>> + rtarget = inst_root + target
>
> I think you can use the join()
no; I used it in an earlier version of the patch
rtarget = os.path.join(inst_root, target[1:])
and this fails for links like '//sbin/systemd'. I could play around
with mangling 'target' through normpath() or lstrip()'ing the '/'.
But concatening the two paths is the best solution because I know that
'target' is absolute and starts with the dir delimiter.
Enrico
next prev parent reply other threads:[~2012-10-14 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-13 12:12 [PATCH] package.bbclass: search for dangling links in installation directory Enrico Scholz
2012-10-14 1:46 ` Chris Larson
2012-10-14 9:51 ` Enrico Scholz [this message]
2012-10-14 14:58 ` Phil Blundell
2012-10-29 15:20 ` Enrico Scholz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=lyvced8jpv.fsf@ensc-virt.intern.sigma-chemnitz.de \
--to=enrico.scholz@sigma-chemnitz.de \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox