Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: jackie.huang@windriver.com
Cc: Zhenfeng.Zhao@windriver.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] eglibc: always compile with optimization.
Date: Mon, 12 Nov 2012 09:48:40 +0000	[thread overview]
Message-ID: <1352713720.6869.107.camel@x121e.pbcl.net> (raw)
In-Reply-To: <88778c5a8e868a75c53ed8e60bb80a2cda17bc8d.1352690328.git.jackie.huang@windriver.com>

On Mon, 2012-11-12 at 11:31 +0800, jackie.huang@windriver.com wrote:
> +# eglibc can't be built without optimization, if someone tries to compile an
> +# entire image as -O0, we override it with -O2 here and give a note about it.
> +def get_optimization(d):
> +    if base_contains("SELECTED_OPTIMIZATION", "-O0", "x", "", d) == "x":
> +        bb.note("eglibc can't be built with -O0, -O2 will be used instead.")
> +        selected_optimization = d.getVar("SELECTED_OPTIMIZATION", True)
> +        return selected_optimization.replace("-O0", "-O2")
> +    return selected_optimization

Did you test this patch at all?

p.





  reply	other threads:[~2012-11-12 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12  3:31 [PATCH 0/1] eglibc: always compile with optimization jackie.huang
2012-11-12  3:31 ` [PATCH 1/1] " jackie.huang
2012-11-12  9:48   ` Phil Blundell [this message]
2012-11-13  1:44     ` jhuang0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352713720.6869.107.camel@x121e.pbcl.net \
    --to=philb@gnu.org \
    --cc=Zhenfeng.Zhao@windriver.com \
    --cc=jackie.huang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox